-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package Flight SQL #793
Package Flight SQL #793
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hmm, I'm going to have to debug that Windows issue (and figure out why our existing CI doesn't catch it). Do we prefer dropping Flight SQL from Windows and proceeding for now, or just holding off with this until 9.0.0 (assuming I get in a fix)? |
If the fix is small, we can also apply a patch on top of 8.0.0 here. |
f4244e7
to
54a6e8d
Compare
Looks like one build flaked. I disabled it on Windows since it's nontrivial to fix (apache/arrow#13434) |
c9af988
to
232d628
Compare
Looks like some of the builds tend to time out (maybe adding Flight SQL is pushing us above the threshold) - wonder if there's some way to speed up the builds or trim things we don't need. I know some of the Arrow CI builds enable unity builds to try to speed things up, maybe that's worth trying here? |
I tried requeueing but we're hitting timeouts on emulated builds here. We should probably try to move towards cross compilation but that's a relatively big lift. |
Unfortunately cross-compiling and CUDA builds don't work together today. |
Doesn't that only apply to device code requiring nvcc? The arrow package just uses the CUDA driver API without any actual device code. We should be able to cross compile against a libcuda stub? |
Which means we need to use the CUDA Docker images. This is part of the issue. |
Any issues with merging this without all of the emulated builds passing? I can then babysit the merge commit jobs to make sure we get packages published. |
None. Though it looks like we are down to one. |
Will give this a chance to finish its run, but if it fails lets merge. |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
Thanks everyone! |
I think I figured out the images part (or at least the rendering part) in #859. Meaning we have x86 build compilers, but I don't yet know how we get the libcuda stub for host (aarch/ppc) into there. We might be able to download it in the build scripts...? |
You're not allowed to redistribute a libcuda stub in a container unless the container was based on the |
I propose to continue the discussion in #859, if that's alright. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Enable the Flight SQL build. This doesn't have any additional dependencies.