-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reinstate aarch64+CUDA; add ppc64le+CUDA #899
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
After conda-forge/conda-forge-ci-setup-feedstock#210 got solved, this is now blocked on conda-forge/nvcc-feedstock#95 |
@conda-forge-admin, rerender |
This reverts commit eb77099.
I'm rebasing this, but need to wait til conda-forge/conda-forge-pinning-feedstock#3624 makes it through the CDN |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Ah, I hadn't seen conda-forge/nvcc-feedstock#96, that's amazing, thanks so much! 🤩 Seems this got through the resolver and now started building! 🥳 Failure is unrelated should be resolvable:
|
a99c38f
to
731c7b6
Compare
It seems this is looking for the wrong gnu stubs?
AFAICT they are named differently in our linux-sysroot? Probably needs a patch? |
…nda-forge-pinning 2023.04.14.07.22.14
Thanks a lot for the help here Isuru! Checking out where the test failures are coming from in #1015. Sidenote, I saw that arrow wants to find libevent, got an open PR to make that happen (I had included it in host here before already, but rebased that out after it wasn't found even then - it needs the cmake config files to be found without further intervention) |
An interesting error while testing pyarrow on the new CUDA builds... aarch:
ppc:
|
The reason this is weird to me is that the error appears on |
Should be fixed by conda-forge/docker-images#233 |
Ah, right, no QEMU in the new cross-images. Thanks a lot! :) |
Something with $CUDA_HOME (or so?) seems to not yet be set up 100% correctly:
|
Should be fixed by conda-forge/conda-forge-ci-setup-feedstock#234 |
Cross-compiling CUDA ✅🥳This PR is now ready for primetime, and I couldn't be more thrilled that we finally got this working. 🤩 ContextBefore arrow 10.x, each python version had a separate CI job, which was already regularly running into the 6h time limit when running in emulation (I was constantly restarting these jobs after merging to the With arrow 10, IOW, we can now add back CUDA-on-aarch, and add support for CUDA-on-ppc!I've also prepared backports of this PR for all our maintenance branches (10.0.x, 9.0.x, 8.0.x). Since we had dropped CUDA-on-aarch for arrow 10, backporting there should be obvious, and since cross-compilation hugely cuts down our CI times (and gets rid of the necessity to restart!) on the PTAL @conda-forge/arrow-cpp PS: It took quite a bit of effort to get this working (wouldn't have happened without @isuruf; a huge thanks! 🙏), here's some indication of what was necessary (no claim of exhaustiveness; just what I'm aware of)...
Footnotes
|
Seems people are less excited about this than I am? 🤔 😅 Unless there are comments to the contrary, I'll merge this (and the maintenance PRs) in 24h. |
A left-over from #875, this is blocked on the slow-moving1 conda-forge/conda-forge-ci-setup-feedstock#210 (more discussion on the why cross-compilation is a de facto necessity here).
Closes #859
Closes #659
Footnotes
This might be further impacted by nvidia deps moving to conda-forge ↩