Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Rebuild for aws_sdk_cpp11057 #936

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update aws_sdk_cpp11057.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/4003699574, please use this URL for debugging.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari h-vetinari changed the title Rebuild for aws_sdk_cpp11057 [main] Rebuild for aws_sdk_cpp11057 Jan 25, 2023
@h-vetinari h-vetinari added automerge Merge the PR when CI passes and removed automerge Merge the PR when CI passes labels Jan 25, 2023
@h-vetinari h-vetinari mentioned this pull request Jan 26, 2023
3 tasks
MNT: Re-rendered with conda-build 3.23.3, conda-smithy 3.22.1, and conda-forge-pinning 2023.01.26.03.13.59
@h-vetinari h-vetinari force-pushed the rebuild-aws_sdk_cpp11057-0-1_he0621b branch from 8a3b06c to 5de3a3e Compare January 26, 2023 05:53
@h-vetinari h-vetinari force-pushed the rebuild-aws_sdk_cpp11057-0-1_he0621b branch 2 times, most recently from a58115a to 5a70fbb Compare January 26, 2023 10:45
@h-vetinari h-vetinari force-pushed the rebuild-aws_sdk_cpp11057-0-1_he0621b branch from 5a70fbb to 3218c8f Compare January 26, 2023 11:44
@h-vetinari h-vetinari force-pushed the rebuild-aws_sdk_cpp11057-0-1_he0621b branch from ed00ea7 to 387290c Compare January 27, 2023 05:12
@h-vetinari
Copy link
Member

@xhochy @kkraus14 @pitrou @kou @jakirkham
This bumps aws-sdk-cpp to 1.10 (upstream is in the process of doing the same). It is not expected that this has problems like the 1.9 series originally did.

For some reason, the link check on unix now complains that it needs symbols from aws-crt-cpp, which we also package. I've added this here, though it means we'll have one more thing to migrate (however, we could couple the aws-{sdk,crt}-cpp migrators of course). More discussion on this in conda-forge/aws-sdk-cpp-feedstock#662.

Otherwise, there's an issue with the gdb integration that has a minimal fix (51b91ef, which however does not make it functional in the final environment), plus an optional activation script (387290c) to ensure no user manipulation of paths is necessary.

These two patches are also in the PR for 9.0.x, because gdb integration landed for v9.

All in all, I don't think there's anything controversial here, so unless there are comments, I'll merge this in 24h.

CC @conda-forge/arrow-cpp

@h-vetinari h-vetinari merged commit 18fc705 into conda-forge:main Jan 30, 2023
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-aws_sdk_cpp11057-0-1_he0621b branch January 30, 2023 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants