Skip to content
This repository was archived by the owner on Mar 12, 2024. It is now read-only.

Fix compatibility with libcxx 16 in boost 1.78 while using compilers used by old 1.78 builds#135

Merged
isuruf merged 5 commits intoconda-forge:v1.78.xfrom
traversaro:patch-1
Apr 5, 2023
Merged

Fix compatibility with libcxx 16 in boost 1.78 while using compilers used by old 1.78 builds#135
isuruf merged 5 commits intoconda-forge:v1.78.xfrom
traversaro:patch-1

Conversation

@traversaro
Copy link

@traversaro traversaro commented Mar 31, 2023

This patch fixes #134 and conda-forge/libcxx-feedstock#114, by backporting boostorg/config#440 on 1.78 . This works as it is also on Boost 1.78 , as just defining BOOST_NO_CXX98_FUNCTION_BASE is ok as then std::unary_function is not used already in boost 1.78, see https://github.com/boostorg/container_hash/blob/boost-1.78.0/include/boost/container_hash/hash.hpp#L123-L133 .

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Author

@conda-forge-admin, please rerender

@traversaro traversaro changed the title Fix compatibility with libcxx 16 in boost 1.78 Fix compatibility with libcxx 16 in boost 1.78 while using old compilers Mar 31, 2023
@traversaro traversaro changed the title Fix compatibility with libcxx 16 in boost 1.78 while using old compilers Fix compatibility with libcxx 16 in boost 1.78 while using compilers used by old 1.78 builds Mar 31, 2023
@traversaro
Copy link
Author

The PR is ready for review. @conda-forge/boost-cpp

Copy link

@hmaarrfk hmaarrfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to have boost-cpp migrated to icu 72.

@ryanvolz
Copy link

ryanvolz commented Apr 5, 2023

I applied this compile definition manually in a build that depends on Boost and it did the job: conda-forge/gnuradio-feedstock#232. It would be really nice to have this merged soon though so it's not necessary to do the same for a bunch of downstream packages.

@isuruf isuruf merged commit f593452 into conda-forge:v1.78.x Apr 5, 2023
@ryanvolz
Copy link

ryanvolz commented Apr 5, 2023

Thanks @isuruf!

@traversaro
Copy link
Author

Thanks a lot @isuruf!

@traversaro traversaro deleted the patch-1 branch April 6, 2023 09:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants