This repository was archived by the owner on Mar 12, 2024. It is now read-only.
Fix compatibility with libcxx 16 in boost 1.78 while using compilers used by old 1.78 builds#135
Merged
isuruf merged 5 commits intoconda-forge:v1.78.xfrom Apr 5, 2023
Merged
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Author
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.03.29.16.02.14
Author
|
The PR is ready for review. @conda-forge/boost-cpp |
4 tasks
1 task
hmaarrfk
approved these changes
Apr 3, 2023
hmaarrfk
left a comment
There was a problem hiding this comment.
I would like to have boost-cpp migrated to icu 72.
6 tasks
|
I applied this compile definition manually in a build that depends on Boost and it did the job: conda-forge/gnuradio-feedstock#232. It would be really nice to have this merged soon though so it's not necessary to do the same for a bunch of downstream packages. |
|
Thanks @isuruf! |
Author
|
Thanks a lot @isuruf! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes #134 and conda-forge/libcxx-feedstock#114, by backporting boostorg/config#440 on 1.78 . This works as it is also on Boost 1.78 , as just defining
BOOST_NO_CXX98_FUNCTION_BASEis ok as thenstd::unary_functionis not used already in boost 1.78, see https://github.com/boostorg/container_hash/blob/boost-1.78.0/include/boost/container_hash/hash.hpp#L123-L133 .Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)