Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to 1.0.4 #6

Merged
merged 2 commits into from
Jul 26, 2018
Merged

update to 1.0.4 #6

merged 2 commits into from
Jul 26, 2018

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Jul 24, 2018

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

recipe/meta.yaml Outdated
sha256: 1df2ec430d34e9034d162969fe1a12cee50fa67cacdcc60d7b57b6c45b576467
# We need a libclang. No one builds them statically for Windows unfortunately (though the
# libav binaries have been built this way). I rename the libclang.dll in these to avoid
# conflicts with conda-forge's clangdev (which we cannot use at present due to compat).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mingwandroid, what were the issues with conda-forge's clangdev?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conda-forge's clangdev is much too modern. I spent a while figuring out the latest official release that still worked OK. The semantics have changed considerably in the cursor / code walking stuff (and I spent waaaay too long on this package to try to modernise that part of it, please feel free if you are interested!)

While we could rummage around in old clangdev packages trying to find one that will work, I'd rather not force old clangdevs into the build environment incase of conflicts so I elected to just bundle an official DLL in a non-conflicting location instead.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But .. why do you ask this? I wrote what I thought was a comprehensive explanation in the comment:

https://github.com/conda-forge/c99-to-c89-feedstock/pull/6/files#diff-e178b687b10a71a3348107ae3154e44cR13

.. did you miss that or did it not make sense or something?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking of using clangdev 3.9.1 from conda-forge and link statically. clangdev builds static libraries so you don't need it at runtime for c99-to-c89. I was just curious by your comment about not being compatible.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be worth a try to link it statically, yes.

recipe/meta.yaml Outdated

build:
number: 0
skip: True # [unix]

skip: true # [win and vc!=14]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this ignore the vc run_exports?

@@ -0,0 +1,174 @@
///////////////////////////////////////////////////////////////////////////////
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocefpaf, can we use these files from the source tarball?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I'll try that.

@ocefpaf ocefpaf force-pushed the 1.0.4 branch 2 times, most recently from b7fa258 to 7268af3 Compare July 25, 2018 01:01
@ocefpaf
Copy link
Member Author

ocefpaf commented Jul 25, 2018

Not sure what is wrong there b/c I used this syntax before with proj :-/

Executing: conda build recipe --quiet
Warning: Treating unknown selector 'vc' as if it was False.
Warning: Treating unknown selector 'vc' as if it was False.
The source field should be a dict, not list in file C:\projects\c99-to-c89-feedstock\recipe\meta.yaml.

@msarahan Am I doing something wrong or did this change?

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'requirements', 'test', 'about', 'extra'].
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).

@msarahan
Copy link
Member

It looks right to me. Seems like this might be a bug from 3.12.0. https://github.com/conda/conda-build/pull/3041/files#diff-c86934c27c2f25579540ddb447fa45bdL334 seems like a likely culprit, but it's not obvious to me what is going wrong.

@ocefpaf
Copy link
Member Author

ocefpaf commented Jul 25, 2018

It looks right to me. Seems like this might be a bug from 3.12.0. conda/conda-build/pull/3041/files#diff-c86934c27c2f25579540ddb447fa45bdL334 seems like a likely culprit, but it's not obvious to me what is going wrong.

Thanks for letting me know I'm not crazy. This has been a terrible morning with virtually everything on my stack (gdal) is broken due to changes in things that are out of my hands :-(

I'm reverting this to @mingwandroid's recipe and if this passes I'll merge it to unblock conda-forge/xz-feedstock#17 and start rebuild the stack, again...

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ocefpaf ocefpaf merged commit 9edfffc into conda-forge:master Jul 26, 2018
@ocefpaf ocefpaf deleted the 1.0.4 branch July 26, 2018 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants