Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gluh to mesa libgl devel #65

Merged
merged 16 commits into from
Feb 26, 2024

Conversation

capn-freako
Copy link
Contributor

Please see the repo readme for directions on how to make PRs on this repo.

Checklist:

  • if you have added a CDT, it appears in the cdt_slugs.yaml file and
    you have rerun the script python gen_cdt_recipes.py.
  • if you have changed the CDT generator code (rpm.py), you have bumped
    the build number in conda_build_config.yaml and have remade all of the
    recipes via running python gen_cdt_recipes.py --force
  • if you have added a custom CDT recipe, you have added the name of the CDT
    with custom: true in the cdt_slugs.yaml file.
  • all CDT recipes have build number set by {{ cdt_build_number }} for
    old-style/legacy CDTs or {{ cdt_build_number|int + 1000 }} for new-style CDTs
  • if you see a warning about a CDT not having a license, you have added the
    license_file key in the cdt_slugs.yaml file with the path to the appropriate
    license in licenses/

NOTE: If you make any changes to cd_slugs.yaml, you need to reun the generator code
via python gen_cdt_recipes.py.

Removed empty build: requirements.
Added `mesa-license` file to two new custom CDT packages.
(They weren't being found by the build.)
Added `mesa-license` file, which I intended to add in previous commit.
Replaced erroneous `mesa-license` file.
Replaced erroneous `mesa-license` file.
Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason these are not being made for cos7? We are dropping cos6 at some point.

@capn-freako
Copy link
Contributor Author

capn-freako commented Mar 28, 2023 via email

@capn-freako
Copy link
Contributor Author

Hi @beckermr , I'm getting this build failure:

WARNING:conda_build.source:Error: HTTP 404 NOT FOUND for url <http://mirror.centos.org/centos/7/os/x86_64/Packages/mesa-libGLU-18.3.4-10.el7.x86_64.rpm>

But, I'm able to fetch this file by hand without issue:

% curl --output mesa-libGLU-18.3.4-10.el7.x86_64.rpm http://mirror.centos.org/centos/7/os/x86_64/Packages/mesa-libGLU-18.3.4-10.el7.x86_64.rpm
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  8271  100  8271    0     0  74249      0 --:--:-- --:--:-- --:--:-- 78028

Any thoughts?

Thanks,
-db

@beckermr
Copy link
Member

Ouch I have no idea. Maybe we need to allow redirects or something?

@capn-freako
Copy link
Contributor Author

Ouch I have no idea. Maybe we need to allow redirects or something?

Is there anyone on the core team, who might have a hunch about this?

@Tobias-Fischer
Copy link
Contributor

@conda-forge-admin please restart ci

@Tobias-Fischer
Copy link
Contributor

So I've had a quick look - this file does not exist anymore:
curl --output mesa-libGLU-18.3.4-10.el7.x86_64.rpm http://mirror.centos.org/centos/7/os/x86_64/Packages/mesa-libGLU-18.3.4-10.el7.x86_64.rpm

Instead, there is only http://mirror.centos.org/centos/7/os/x86_64/Packages/mesa-libGLU-9.0.0-4.el7.x86_64.rpm
The version difference is very odd though. Not sure what's going on .. do you happen to know @beckermr?

@Tobias-Fischer
Copy link
Contributor

I now suspect that the curl command only downloaded the 404 error page, based on the file size above. So I think we just need to change the version. @capn-freako if you give me access to your fork, I'll do it.

@beckermr
Copy link
Member

@Tobias-Fischer I thought that rpm link was autogenerated, so IDK why it is not there.

@Tobias-Fischer
Copy link
Contributor

I think the link was manually generated by changing GL (works) to GLU. Could you please confirm @capn-freako

@capn-freako
Copy link
Contributor Author

I now suspect that the curl command only downloaded the 404 error page, based on the file size above. So I think we just need to change the version. @capn-freako if you give me access to your fork, I'll do it.

Done.

@capn-freako
Copy link
Contributor Author

I think the link was manually generated by changing GL (works) to GLU. Could you please confirm @capn-freako

Sorry, I don't understand what my action is here. :(

@Tobias-Fischer
Copy link
Contributor

Hi @beckermr @capn-freako - this is the first time I've touched CDTs. All tests are passing, it would be great if you could take a look. Basically all I've done from the groundwork that @capn-freako did is change the version of GLU to 9.0.0 as that is what CentOS7 has.

@beckermr beckermr merged commit 0154c60 into conda-forge:main Feb 26, 2024
8 checks passed
@Tobias-Fischer Tobias-Fischer deleted the add-gluh-to-mesa-libgl-devel branch February 26, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants