-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gluh to mesa libgl devel #65
Add gluh to mesa libgl devel #65
Conversation
Removed empty build: requirements.
Added `mesa-license` file to two new custom CDT packages. (They weren't being found by the build.)
Added `mesa-license` file, which I intended to add in previous commit.
Replaced erroneous `mesa-license` file.
Replaced erroneous `mesa-license` file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason these are not being made for cos7? We are dropping cos6 at some point.
No. Actually, I’ve been meaning to ask about that.
I’m just trying to work through my build failures, for the cos6 case, first.
(This is my first attempted contribution and I’m still very confused about how all the pieces fit together.)
-db
… On Mar 28, 2023, at 9:24 AM, Matthew R. Becker ***@***.***> wrote:
@beckermr commented on this pull request.
Is there a reason these are not being made for cos7? We are dropping cos6 at some point.
—
Reply to this email directly, view it on GitHub <#65 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH7XGUPLB4ZMNV2EK47XS3W6LRBNANCNFSM6AAAAAAWHSR6HY>.
You are receiving this because you authored the thread.
|
Hi @beckermr , I'm getting this build failure:
But, I'm able to fetch this file by hand without issue:
Any thoughts? Thanks, |
Ouch I have no idea. Maybe we need to allow redirects or something? |
Is there anyone on the core team, who might have a hunch about this? |
@conda-forge-admin please restart ci |
So I've had a quick look - this file does not exist anymore: Instead, there is only http://mirror.centos.org/centos/7/os/x86_64/Packages/mesa-libGLU-9.0.0-4.el7.x86_64.rpm |
I now suspect that the curl command only downloaded the 404 error page, based on the file size above. So I think we just need to change the version. @capn-freako if you give me access to your fork, I'll do it. |
@Tobias-Fischer I thought that rpm link was autogenerated, so IDK why it is not there. |
I think the link was manually generated by changing GL (works) to GLU. Could you please confirm @capn-freako |
Done. |
Sorry, I don't understand what my action is here. :( |
Hi @beckermr @capn-freako - this is the first time I've touched CDTs. All tests are passing, it would be great if you could take a look. Basically all I've done from the groundwork that @capn-freako did is change the version of GLU to 9.0.0 as that is what CentOS7 has. |
Please see the repo readme for directions on how to make PRs on this repo.
Checklist:
cdt_slugs.yaml
file andyou have rerun the script
python gen_cdt_recipes.py
.rpm.py
), you have bumpedthe build number in
conda_build_config.yaml
and have remade all of therecipes via running
python gen_cdt_recipes.py --force
with
custom: true
in thecdt_slugs.yaml
file.{{ cdt_build_number }}
forold-style/legacy CDTs or
{{ cdt_build_number|int + 1000 }}
for new-style CDTslicense_file
key in thecdt_slugs.yaml
file with the path to the appropriatelicense in
licenses/
NOTE: If you make any changes to
cd_slugs.yaml
, you need to reun the generator codevia
python gen_cdt_recipes.py
.