Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to version 1.0.3 #4

Merged
merged 4 commits into from
Oct 10, 2018
Merged

Update to version 1.0.3 #4

merged 4 commits into from
Oct 10, 2018

Conversation

hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented Jun 8, 2018

I also modernized the script

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ocefpaf
Copy link
Member

ocefpaf commented Jul 14, 2018

@conda-forge-admin, please rerender

@ocefpaf ocefpaf mentioned this pull request Jul 14, 2018
@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Aug 6, 2018

@conda-forge-admin, please rerender

@conda-forge-linter

This comment has been minimized.

@conda-forge-linter

This comment has been minimized.

@conda-forge-linter

This comment has been minimized.

@hmaarrfk hmaarrfk changed the title Updated numpy pinning Update to version 1.0.3 Sep 30, 2018
@hmaarrfk hmaarrfk force-pushed the new_numpy branch 2 times, most recently from 6d3cf57 to 5a4de1c Compare September 30, 2018 04:21
@hmaarrfk
Copy link
Contributor Author

@jwiggins just a friendly ping about updating this package on conda-forge. If you would like, I could add myself as a maintainer to take some load off you.

recipe/meta.yaml Outdated
- numpy >=1.11
- freetype 2.6.*
- {{ pin_compatible('numpy') }}
- freetype >=2.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this pin and let the re-rendering take care of that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

freetype?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. On host and run.

@hmaarrfk hmaarrfk force-pushed the new_numpy branch 2 times, most recently from 9d7e260 to bf11775 Compare September 30, 2018 19:49
@jwiggins
Copy link
Member

jwiggins commented Oct 1, 2018

@hmaarrfk Yes, I would appreciate the help.

(I'm now watching this repo. Sorry for not responding earlier)

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Oct 1, 2018

@jwiggins cool, FYI, the windows build error is likely due to conda-forge/scikit-image-feedstock#30 (comment)

@jwiggins
Copy link
Member

jwiggins commented Oct 1, 2018

So we're basically waiting for fixes to happen upstream before this can be merged?

@ocefpaf
Copy link
Member

ocefpaf commented Oct 1, 2018

So we're basically waiting for fixes to happen upstream before this can be merged?

If you want to "cash" in the OS X and Linux packages you can go ahead and merge this. Just open an issue to tracker the Windows problem there.

@jwiggins
Copy link
Member

jwiggins commented Oct 1, 2018

I'm not in any particular hurry

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Oct 1, 2018

neither am I really, I got good at rebasing and rerending in case conda-smithy changes.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Oct 2, 2018

@ocefpaf
Copy link
Member

ocefpaf commented Oct 3, 2018

@ocefpaf any clue why this error is showing up ci.appveyor.com/project/conda-forge/celiagg-feedstock/build/1.0.19/job/j43k1cruydyeccxy#L632

No idea. Sorry... Windows is not my thing :-/

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Oct 8, 2018

@jwiggins I guess Windows builds are also new for celiagg, but any idea why the following happens:

@isuruf @ 00:27 on gitter said:

It's a weird issue.
pip + numpy 1.12 works
pip + numpy 1.11 doesn't
python setup.py + numpy 1.12 works
python setup.py + numpy 1.11 works

@jwiggins
Copy link
Member

jwiggins commented Oct 8, 2018

Looks like it passed! (🎊)

Does 3.5 support need to be dropped? What do you mean by "pinning 2018.10.03" in your commit message?

@jwiggins
Copy link
Member

jwiggins commented Oct 8, 2018

And to answer your question, no, I don't know why the recipe fails for pip + numpy 1.11. I only remember having trouble with Python 3.4 back when I last worked on this recipe.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Oct 8, 2018

@jwiggins I think we can revert to an older version of conda-smithy and conda-forge-pinning and rerender the recipe.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Oct 9, 2018

@jwiggins this should build for python 3.5. We can rerender again after that.

@hmaarrfk
Copy link
Contributor Author

@jwiggins friendly ping. I would merge this before something crazy happens with Travis making 3.5 compilation impossible again or the bot for 3.7 migration comes around.

@jwiggins jwiggins merged commit daddc56 into conda-forge:master Oct 10, 2018
@jwiggins
Copy link
Member

Thanks for sticking with this!

@jwiggins
Copy link
Member

The build was clean(-ish. Had to restart linux3.5): https://anaconda.org/conda-forge/celiagg/files?version=1.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants