-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to version 1.0.3 #4
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
@conda-forge-admin, please rerender |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
6d3cf57
to
5a4de1c
Compare
@jwiggins just a friendly ping about updating this package on conda-forge. If you would like, I could add myself as a maintainer to take some load off you. |
recipe/meta.yaml
Outdated
- numpy >=1.11 | ||
- freetype 2.6.* | ||
- {{ pin_compatible('numpy') }} | ||
- freetype >=2.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove this pin and let the re-rendering take care of that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
freetype?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. On host
and run
.
9d7e260
to
bf11775
Compare
@hmaarrfk Yes, I would appreciate the help. (I'm now watching this repo. Sorry for not responding earlier) |
@jwiggins cool, FYI, the windows build error is likely due to conda-forge/scikit-image-feedstock#30 (comment) |
So we're basically waiting for fixes to happen upstream before this can be merged? |
If you want to "cash" in the |
I'm not in any particular hurry |
neither am I really, I got good at rebasing and rerending in case conda-smithy changes. |
@ocefpaf any clue why this error is showing up https://ci.appveyor.com/project/conda-forge/celiagg-feedstock/build/1.0.19/job/j43k1cruydyeccxy#L632 |
No idea. Sorry... Windows is not my thing :-/ |
Looks like it passed! (🎊) Does 3.5 support need to be dropped? What do you mean by "pinning 2018.10.03" in your commit message? |
And to answer your question, no, I don't know why the recipe fails for pip + numpy 1.11. I only remember having trouble with Python 3.4 back when I last worked on this recipe. |
@jwiggins I think we can revert to an older version of conda-smithy and conda-forge-pinning and rerender the recipe. |
@jwiggins this should build for python 3.5. We can rerender again after that. |
@jwiggins friendly ping. I would merge this before something crazy happens with Travis making 3.5 compilation impossible again or the bot for 3.7 migration comes around. |
Thanks for sticking with this! |
The build was clean(-ish. Had to restart linux3.5): https://anaconda.org/conda-forge/celiagg/files?version=1.0.3 |
I also modernized the script