-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate artefact collection; build for all VS & clang versions #18
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
I'm thinking we should keep this here but perhaps build for the 2x2 matrix of supported (= two latest) VS resp. clang versions? |
0aebc09
to
c4c967b
Compare
0c8f630
to
551a96d
Compare
3c7b738
to
80b1d02
Compare
@xhochy @isuruf I've tried to document my understanding of where the various versions come from, and I'd very much appreciate your review on this, as well as the automation of course (though the fact that it works should hopefully speak for itself). Importantly, I'm still inserting hard-coded links into the activation scripts (at installation time), so in principle they run exactly as before. As far as I understand it, for full functionality we actually need the whole matrix of VS-versions times clang-versions that we have live in conda-forge; I've built this up incrementally: first automate only VS2017, then expand the VS-versions in CBC, then expand the clang matrix as well. You can see that the CI for all these stages is passing -- obviously we have a choice to reduce the matrix as desired. PTAL |
# component=$(echo $map | cut -d '|' -f1) | ||
url=$(echo $map | cut -d '|' -f2) | ||
# download and unpacks into Contents/VC/Tools/MSVC/${MSVC_HEADERS_VERSION}/... | ||
curl -L $url -o tmp.zip && unzip -oqq tmp.zip && rm tmp.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After I had scripted all the automation, I ended up not using the component name explicitly in the activation script. I still think it's a value add to keep it, as that makes the activation script way more self-explanatory with the component names in COMPONENT_URLS
, than if it were just a list of obfuscated URLs.
…nda-forge-pinning 2023.04.07.12.23.44
…nda-forge-pinning 2023.04.07.12.23.44
…nda-forge-pinning 2023.04.07.12.23.44
sed-replace directly with ${CHOST_BASE}${CL_VERSION} in install-pkg.sh
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
Co-authored-by: Isuru Fernando <isuruf@gmail.com>
…nda-forge-pinning 2023.04.12.20.43.24
...inux_64_MSVC_HEADERS_VERSION14.29.30133TOOLCHAIN_COMBINED14.29.16.11clang_version15.0.7.yaml
Outdated
Show resolved
Hide resolved
…nda-forge-pinning 2023.04.12.20.43.24
Thanks |
So far, I've just been updating this recipe from the clang side, but I realize now that it's still depending on VS2017, and hasn't yet switched to the new VS2019 default.
But I realised that to be fully usable, this recipe needs to be built for all our available VS versions (as well as all our live clang versions), but that becomes very unwieldy and tiresome with all the hardcoded components/urls.
So I automated this and then expanded the build matrix. I also added myself to maintainers now.