Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to clang-cl when using .bat / .ps1 activation #48

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

h-vetinari
Copy link
Member

Not sure why our default here on windows is

set "CC=clang.exe"
set "NM=llvm-nm.exe"
set "LD=lld-link.exe"

This is inconsistent in the sense that lld-link does not recognize -L (needs /LIBPATH:), wheras clang.exe does not recognize /LIBPATH: and needs -L.

IMO it would make sense for our clang compilers on windows to default to clang-cl; alternatively we could consider having separate compilers called clang{,xx}-cl_win-64? Then it would just be a matter of doing the following in CBC:

 c_compiler:                # [win]
-- clang                    # [win]
+- clang-cl                 # [win]
 cxx_compiler:              # [win]
-- clangxx                  # [win]
+- clangxx-cl               # [win]

Thoughts @xhochy @isuruf?

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@xhochy
Copy link
Member

xhochy commented Nov 15, 2024

We should have separate compilers. In the cases where I use clang for Windows, I actually want clang.exe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants