-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-rendering 13.x #300
base: 13.x
Are you sure you want to change the base?
Re-rendering 13.x #300
Conversation
…nda-forge-pinning 2024.07.04.12.04.07
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
Interestingly, we're missing the path for the C++ stdlib here:
whereas the path we'd need is:
I think you might want to try backporting #231 |
Co-authored-by: h-vetinari <h.vetinari@gmx.com>
At first, I was also wondering why the PPC builds are passing here, but as it turns out, this is because we still have an old pin set for these clangdev-feedstock/recipe/conda_build_config.yaml Lines 16 to 17 in e7fd70b
This results in
Coming back to linux-64, things look exactly the same
but then we get
This just doesn't make sense to me, because this path (which boils down to |
…nda-forge-pinning 2024.07.10.03.09.24
This is very interesting! For some reason, by forcing the |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Sorry for the long delays here; since clang 13.x is basically completely out of support, it's probably not a good use of our time to dig too deeply what's going on exactly. If things build fine with GCC 8, that's good enough for me for now! |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like I wasn't able to push to the 13.x-rerender branch of vepadulano/clangdev-feedstock. Did you check the "Allow edits from maintainers" box? NOTE: Our webservices cannot push to PRs from organization accounts or PRs from forks made from organization forks because of GitHub permissions. Please fork the feedstock directly from conda-forge into your personal GitHub account. This message was generated by GitHub actions workflow run https://github.com/conda-forge/clangdev-feedstock/actions/runs/10346884883. |
OK, I've merged an update to the 13.x branch in #307; you can rebase this PR to migrate root, or whatever it is you were after. I didn't optimize the compiler versions - you'll probably be able to bump GCC a bit further (if you backport 8d12866), and libcxx 17 should also still roughly work with clang 13. In any case, both versions are just a simple change in |
since conda-forge/conda-forge-pinning-feedstock@408e182 forces a more modern libcxx on macOS, pinning here to libcxx breaks downstream packages such as cppyy, see conda-forge/cppyy-cling-feedstock#62 (comment) As indicated in conda-forge#300 (comment) there should be no problem using libcxx 17 here as well.
Opening this PR as a check against #299 .