Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conda v22.9.0 #2 #176

Merged
merged 4 commits into from
Sep 27, 2022
Merged

conda v22.9.0 #2 #176

merged 4 commits into from
Sep 27, 2022

Conversation

jezdez
Copy link
Member

@jezdez jezdez commented Sep 22, 2022

Replacing #175.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jezdez jezdez changed the title 22.9.0 he4310d conda v22.9.0 #2 Sep 22, 2022
@jezdez
Copy link
Member Author

jezdez commented Sep 22, 2022

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-feedstock/actions/runs/3105701679.

@jezdez jezdez requested a review from chenghlee September 22, 2022 13:27
@jezdez jezdez mentioned this pull request Sep 22, 2022
13 tasks
@dbast
Copy link
Member

dbast commented Sep 26, 2022

@jezdez Is that remaining patch intended to be upstreamed, so that it does not require forward porting again with a new conda version?

@jakirkham
Copy link
Member

Was there some discussion about the move to CalVer somewhere?

@travishathaway
Copy link
Contributor

@jakirkham,

CalVer is outlined in CEP 8 and the voting/discussion happen on this pull request.

@beckermr
Copy link
Member

LGTM!

I made an announcement on the conda-forge side since this is a pretty big change.

conda-forge/conda-forge.github.io@498b3b2

@beckermr beckermr merged commit 8d756ad into conda-forge:main Sep 27, 2022
@jezdez jezdez deleted the 22.9.0_he4310d branch September 27, 2022 11:28
@jezdez
Copy link
Member Author

jezdez commented Sep 27, 2022

Thank you @beckermr!

@jaimergp
Copy link
Member

We might need a new build, there are some dependency changes that didn't make it to this PR:

Check the cross-repo diff.

image

@jaimergp
Copy link
Member

Well the diff was a bit more dramatic than needed. It's only ruamel_yaml.

PR here #177

@beckermr
Copy link
Member

We should mark the old one as broken if needed.

@beckermr
Copy link
Member

Not needed. Simply a looser pin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants