-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update conda to 4.2 #6
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Should I read this comment as this is ready? |
It's ready indeed! |
Just bumped to 4.2.7. |
8ab7fca
to
4cdca01
Compare
We''re at 4.2.9 now. Anyone? |
Am waiting for @mcg1969 or @msarahan to sign off on/merge PR ( conda-forge/conda-env-feedstock#1 ) just as you. |
As discussed with @kalefranz I'd like to make sure @msarahan is good with the signoff here because of the interaction with conda build. |
Fine with me. Things seem to be working fine for me with conda 4.2 and conda-build 2.0.2. |
Note: Added a "closes" line in the OP to close out an older PR in the same vein. |
I think this will fix conda/conda-build#1459 which is breaking mpl's appveyor builds :/ |
@tacaswell sorry about that. I am tagging 2.0.6 momentarily just for that big fubar. |
@msarahan No worries, greatly appreciate that your are fixing it! |
@tacaswell 2.0.6 should be available. |
@kalefranz -- looks like this needs a rebase now (and may as well bump to 4.2.9, I suppose). It would be nice to get this merged soon so that the conda-forge |
I just released conda 4.2.11 tonight. I'll update the PR, but I won't merge it; I don't want to merge my own PR. Another maintainer or someone else from conda-forge will need to hit the merge button. |
e9cbf12
to
77c1e5d
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@kalefranz -- could you please restart the failed appveyor build? |
For whoever ultimately clicks the merge button, I highly recommend you make conda-forge/conda-env-feedstock#1 available first. Actually, conda won't even install without it. But I guess most people would probably fall back to the conda-env in the defaults channel. |
Though I see the green merge buttons, I'm not technically a maintainer on either conda or on conda-env. Sounds like there is some limited potential for someone getting a bad combination of conda/conda-env (conda-forge/conda-env-feedstock#1) but that opportunity should exist only for a narrow window of time. @msarahan or @mcg1969 can you please merge the conda-env PR and then this one? We could wait until late tonight if that would help minimize potential conflitcts (and the CI services are faster then). |
Ok guys it's time someone takes action on this. Feel free to remove me as a maintainer if anyone feels I'm acting inappropriately. But I'm going to go ahead and merge conda and conda-env. I think it's safest to merge them at about the same time, with most people likely having |
+1 -- this needed to move forward, I think. |
* Update to 4.13.0. * Do not run upstream test suite Reduces package size; avoids false-positive security warnings (e.g., https://github.com/ContinuumIO/anaconda-issues#12937) * add license_family to meta.yaml Co-authored-by: Cheng H. Lee <clee@anaconda.com> Co-authored-by: avalon (they/them) <avalon@anaconda.com>
Closes #4
Conda 4.2 is being prepared for GA. Will update this PR once it's ready.