Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppVeyor: Workaround for PermissionError during shutil.rmtree #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mbargull
Copy link
Member

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy
  • Ensured the license file is being packaged.

Might resolve gh-14 or at least make it occur less frequently.

It looks like it's very possible that the cleanup shutil.rmtree(dn) call fails on Windows due to open file handles or such. Sleeping a short while and trying again might help. Seems like conda-build suffers the same fate, see conda-forge/conda-feedstock#52.
NOTE: That 0.1 second duration is chosen arbitrarily; maybe it could be shorter, maybe it should be longer, I don't know.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mbargull
Copy link
Member Author

If you think this change makes sense, should this get a build or a version number bump? I assume the latter?

@scopatz
Copy link
Member

scopatz commented May 21, 2018

I believe that @CJ-Wright has seen this in a few cases and has a more robust solution for windows, somewhere. Where was that lying?

@mbargull
Copy link
Member Author

and has a more robust solution for windows, somewhere

That'd be great! I know @kalefranz has been (and I think still is?) battling those beasts for conda, too. (I deliberately ignored those issues and his progress on this, though -- sorry Kale 😉.)
Be sure to let us know if you got something on this, @CJ-Wright, please 😄.

@CJ-Wright
Copy link
Member

@scopatz
Copy link
Member

scopatz commented May 21, 2018

Yup that is it!

mbargull added a commit to mbargull-feedstocks/conda-feedstock that referenced this pull request May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sporadic cleanup issues on AppVeyor after upload
4 participants