Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the case where build number is sometimes a int. #28

Merged
merged 1 commit into from
Sep 10, 2018
Merged

Fix the case where build number is sometimes a int. #28

merged 1 commit into from
Sep 10, 2018

Conversation

hmaarrfk
Copy link
Contributor

Fixes #25

If i bump the build number, this will conflict with #21 🐩

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ocefpaf
Copy link
Member

ocefpaf commented Sep 10, 2018

LGTM

@ocefpaf ocefpaf requested a review from isuruf September 10, 2018 21:30
@ocefpaf
Copy link
Member

ocefpaf commented Sep 10, 2018

@isuruf this is critical to some split-packages. Do you mind taking a quick look?

@ocefpaf ocefpaf merged commit cf24a9c into conda-forge:branch2.0 Sep 10, 2018
@hmaarrfk
Copy link
Contributor Author

Thanks!

@hmaarrfk hmaarrfk deleted the build_number_int_fix branch September 10, 2018 22:07
@ocefpaf
Copy link
Member

ocefpaf commented Sep 10, 2018

Thanks for this one and for #21 @hmaarrfk!

@hmaarrfk
Copy link
Contributor Author

I think we need a version bump for this one to actually get uploaded.

@hmaarrfk
Copy link
Contributor Author

It seems to have been included. Nvm.

@hmaarrfk hmaarrfk mentioned this pull request Nov 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isuruf isuruf isuruf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hmaarrfk @conda-forge-linter @ocefpaf @isuruf