Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow some condarc values in conda-forge.yml #364

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jakirkham
Copy link
Member

Based on the values permitted in condarc, this takes a subset that looks safe for users to configure (and are not already provided some other way) and lets users add them to conda-forge.yml under the conda key. This can be useful when workaround a Conda idiosyncrasy in a particular feedstock build, for adjusting debug information, configuring threads for some operations, or enabling additional safety or error checks.


Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This function isn't related to `.conda` any more. So rename for
clarity.
@jakirkham jakirkham requested a review from a team as a code owner November 6, 2024 22:33
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@jakirkham jakirkham force-pushed the enable_condarc_conda_configs branch from 24f71e2 to 6d569b2 Compare November 6, 2024 22:39
@jaimergp
Copy link
Member

jaimergp commented Nov 7, 2024

Do we want these to affect the initial conda installation with Miniforge (when conda_install_tool = conda)? Because in that case, ci-setup is a bit too late for that and we'd need it in conda-smithy + rerender.

If not, the only comment I have is that this should also be added to the conda-forge.yml schema in conda-smithy.

@jakirkham
Copy link
Member Author

I didn't think so. Figured the purpose of this would be to affect things related to the build that are simply outside the conda_build key

Certainly it would be possible to expand the affected parts of the build later

Yep that makes sense. Wanted to wait and see if there were thoughts on this change before writing more pieces

Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thank you!

@beckermr
Copy link
Member

beckermr commented Nov 8, 2024

Thought for a future PR. Do we want to support a single condarc key instead of the two conda-build and conda keys?

@isuruf
Copy link
Member

isuruf commented Dec 12, 2024

We should keep this allowlist in conda-smithy, so that we can lint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants