-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow some condarc
values in conda-forge.yml
#364
base: main
Are you sure you want to change the base?
Allow some condarc
values in conda-forge.yml
#364
Conversation
This function isn't related to `.conda` any more. So rename for clarity.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
24f71e2
to
6d569b2
Compare
Do we want these to affect the initial If not, the only comment I have is that this should also be added to the conda-forge.yml schema in conda-smithy. |
I didn't think so. Figured the purpose of this would be to affect things related to the build that are simply outside the Certainly it would be possible to expand the affected parts of the build later Yep that makes sense. Wanted to wait and see if there were thoughts on this change before writing more pieces |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and thank you!
Thought for a future PR. Do we want to support a single condarc key instead of the two conda-build and conda keys? |
We should keep this allowlist in conda-smithy, so that we can lint. |
Based on the values permitted in
condarc
, this takes a subset that looks safe for users to configure (and are not already provided some other way) and lets users add them toconda-forge.yml
under theconda
key. This can be useful when workaround a Conda idiosyncrasy in a particular feedstock build, for adjusting debug information, configuring threads for some operations, or enabling additional safety or error checks.Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)