-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gcc 9 for CUDA 11 #1053
Use gcc 9 for CUDA 11 #1053
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Not sure if this achieves what I think... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried a rerendering of a feedstock with this? Copy this into cupy-feedstock, remove the timestamp and rerender. You'll find that it wouldn't work.
Thanks, @isuruf. I was following @h-vetinari's suggestion (#1000 (comment)). So what's the proper way to achieve the desired effect? I suppose you're saying zipping either in the global pinning (#1051 (comment)) or in the migrator (as done here) just wouldn't work, so I am lost... |
I'll let you know if I find one. 😄 |
So, there's a bunch of problems here I think:
I think that it should be feasible after the migrator has run through to expand the zip_keys in the pinning feedstock... WDYT, @isuruf? |
My understanding is that expanding |
@isuruf Does the way we handle keys zipped with docker_image in the latest smithy help here? |
Nope |
What if we added |
@jakirkham, please read @kkraus14's comment above |
Right we can include one for the |
I don't know whether you understood @kkraus14's comment or not. So, I'll say it again. Expanding |
I don't think that is necessarily the case. |
Well, I've tried it multiple times before and I can tell you that it will be. Have you tried even once? |
I think this PR is moot now that we have a proper mechanism to zip the C/C++ compiler version with the nvcc version 🙂 |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Close #1000.