Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to vs2019/vc142 #3167

Merged
merged 1 commit into from
Aug 25, 2022
Merged

move to vs2019/vc142 #3167

merged 1 commit into from
Aug 25, 2022

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Jul 27, 2022

Action item from the core meeting just now.

Full discussion is in conda-forge/conda-forge.github.io#1732. The important part is that this is ABI-compatible with all currently deployed windows artefacts (in fact, many feedstocks are using vs2019 already and happily mixing with vs2017 builds), so we do not need a migration.

Closes conda-forge/conda-forge.github.io#1732

@h-vetinari h-vetinari requested a review from a team as a code owner July 27, 2022 18:15
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

@conda-forge/core
Per the announcement two weeks ago, we should merge this PR today (assuming no complaints arrived).

@isuruf
Copy link
Member

isuruf commented Aug 25, 2022

Did you check that nvcc=10.2 works with vc142 toolchain?

@h-vetinari
Copy link
Member Author

Did you check that nvcc=10.2 works with vc142 toolchain?

Has been running without issue for at least 1.5 years (example from faiss: conda-forge/faiss-split-feedstock@15fe1bf)

@h-vetinari
Copy link
Member Author

h-vetinari commented Aug 25, 2022

Did you check that nvcc=10.2 works with vc142 toolchain?

Has been running without issue for at least 1.5 years (example from faiss: conda-forge/faiss-split-feedstock@15fe1bf)

aaaaaargh, sorry, spoke too soon. conda-forge only did cuda-on-win for nvcc=11.0+ 🤦

@isuruf isuruf merged commit c479373 into conda-forge:main Aug 25, 2022
@h-vetinari h-vetinari deleted the vc142 branch August 25, 2022 16:46
@leofang
Copy link
Member

leofang commented Sep 1, 2022

@h-vetinari vc2019 hates CUDA 11.2: conda-forge/cupy-feedstock#179 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to vc142 toolchain on windows
4 participants