Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stdlib metapackages to pinning #5499

Merged
merged 1 commit into from
Feb 16, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions recipe/conda_build_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,15 @@ c_compiler_version: # [unix]
- 16 # [osx]
- 10 # [os.environ.get("CF_CUDA_ENABLED", "False") == "True" and linux]
- 11 # [os.environ.get("CF_CUDA_ENABLED", "False") == "True" and linux]
c_stdlib:
- sysroot # [linux]
- macosx_deployment_target # [osx]
- vs # [win]
c_stdlib_version: # [unix]
- 2.12 # [linux64]
- 2.17 # [aarch64 or ppc64le]
- 10.9 # [osx and x86_64]
- 11.0 # [osx and arm64]
Comment on lines +11 to +19
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The macOS keys appear not to be in order

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or should there be a Windows version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, windows doesn't set a version, similar to how the windows compilers don't have c_compiler_version

cxx_compiler:
- gxx # [linux]
- clangxx # [osx]
Expand Down Expand Up @@ -159,6 +168,9 @@ zip_keys:
- # [win64 and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
- cuda_compiler # [win64 and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
- cuda_compiler_version # [win64 and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
- # [unix]
- c_stdlib # [unix]
- c_stdlib_version # [unix]
Comment on lines +171 to +173
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this appears to be its own group, it looks like the bot might be lumping them together. Not sure why that is

Taking this from a recent bot migration run:

  ValueError: Variant configuration errors in /home/runner/.cache/conda-smithy/conda_build_config.yaml:
    zip fields in zip_key group frozenset({'cuda_compiler_version', 'fortran_compiler_version', 'cxx_compiler_version', 'cuda_compiler', 'c_compiler_version', 'docker_image', 'cdt_name', 'c_stdlib_version', 'c_stdlib'}) are not all the same length

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this just happens when re-rendering a feedstock: conda-forge/ucx-split-feedstock#158 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am thinking we may need to fold this into the zip_keys group(s) above instead of having it separate

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh am now seeing this did happen: #5592

Somehow got an old diff

-
- python
- numpy
Expand Down