Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More patching for xarray and pandas incompatibility #429

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented Apr 5, 2023

I'm really just trying to ensure

mamba create --name xr "xarray<2023" pandas=2 --channel conda-forge --override-channels

just fail

Checklist

  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.

I'm really just trying to ensure

```
mamba create --name xr "xarray<2023" pandas=2 --channel conda-forge --override-channels
```
just fail
@hmaarrfk hmaarrfk requested a review from a team as a code owner April 5, 2023 20:34
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Apr 5, 2023

diff.txt

well the diff has 2k lines. so i don't think i can copy it.

@jakirkham
Copy link
Member

cc @dcherian @ocefpaf

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Apr 5, 2023

I'm not really proud of this one, but the error logs are pretty nonsensical, so I'm just trying to ensure for the best "user experience"

@ocefpaf
Copy link
Member

ocefpaf commented Apr 5, 2023

I'm not really proud of this one, but the error logs are pretty nonsensical, so I'm just trying to ensure for the best "user experience"

I'm not against it but is it worth it? pandas 1, 1.5 is probably not even installable with the old xarray/numpy in those solves. I'd be more conservative and patch what most users are using at the moment. We can't really ensure compatibility down to the first package ever released.

@dcherian
Copy link

dcherian commented Apr 6, 2023

well apparently now envs get solved with xarray=0.19 and pandas=2 (dask/dask#10152) so this seems like a good idea.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Apr 6, 2023

well apparently now envs get solved with xarray=0.19 and pandas=2

This was my motivation.

The old packages just don't have the same kinds of constraints, so as we add constraints to the new packages, the solver increasingly prefers constraint-less old packages.

@jakirkham
Copy link
Member

Should we give it a try then?

@ocefpaf
Copy link
Member

ocefpaf commented Apr 6, 2023

Let's go for it then. I guess y always constraint my envs with a min version for the new CalVer era, so I'm not seeing this.

@ocefpaf ocefpaf merged commit 1d68ef2 into conda-forge:main Apr 6, 2023
@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Apr 6, 2023

with a min version for the new CalVer

Interesting.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Apr 7, 2023

mamba create --name xr "xarray<2023" pandas=2 --channel conda-forge --override-channels

                  __    __    __    __
                 /  \  /  \  /  \  /  \
                /    \/    \/    \/    \
███████████████/  /██/  /██/  /██/  /████████████████████████
              /  / \   / \   / \   / \  \____
             /  /   \_/   \_/   \_/   \    o \__,
            / _/                       \_____/  `
            |/
        ███╗   ███╗ █████╗ ███╗   ███╗██████╗  █████╗
        ████╗ ████║██╔══██╗████╗ ████║██╔══██╗██╔══██╗
        ██╔████╔██║███████║██╔████╔██║██████╔╝███████║
        ██║╚██╔╝██║██╔══██║██║╚██╔╝██║██╔══██╗██╔══██║
        ██║ ╚═╝ ██║██║  ██║██║ ╚═╝ ██║██████╔╝██║  ██║
        ╚═╝     ╚═╝╚═╝  ╚═╝╚═╝     ╚═╝╚═════╝ ╚═╝  ╚═╝

        mamba (1.4.2) supported by @QuantStack

        GitHub:  https://github.com/mamba-org/mamba
        Twitter: https://twitter.com/QuantStack

█████████████████████████████████████████████████████████████


Looking for: ["xarray[version='<2023']", 'pandas=2']

conda-forge/linux-64                                        Using cache
conda-forge/noarch                                          Using cache
Could not solve for environment specs
The following packages are incompatible
├─ pandas 2**  is installable with the potential options
│  ├─ pandas 2.0.0 would require
│  │  └─ python_abi 3.10.* *_cp310, which can be installed;
│  ├─ pandas 2.0.0 would require
│  │  └─ python_abi 3.11.* *_cp311, which can be installed;
│  ├─ pandas 2.0.0 would require
│  │  └─ python_abi 3.8 *_pypy38_pp73, which can be installed;
│  ├─ pandas 2.0.0 would require
│  │  └─ python_abi 3.8.* *_cp38, which can be installed;
│  ├─ pandas 2.0.0 would require
│  │  └─ python_abi 3.9.* *_cp39, which can be installed;
│  └─ pandas 2.0.0 would require
│     └─ python_abi 3.9 *_pypy39_pp73, which can be installed;
└─ xarray <2023  is uninstallable because there are no viable options
   ├─ xarray [0.10.0|0.10.1|...|0.9.6] would require
   │  └─ python_abi * *_cp27mu, which conflicts with any installable versions previously reported;
   ├─ xarray [0.10.0|0.10.1|...|0.9.6] would require
   │  └─ python_abi * *_cp35m, which conflicts with any installable versions previously reported;
   ├─ xarray [0.10.0|0.10.1|...|0.9.6] would require
   │  └─ python_abi * *_cp36m, which conflicts with any installable versions previously reported;
   ├─ xarray [0.10.8|0.10.9|0.11.0|0.11.2|0.11.3] would require
   │  └─ python_abi * *_cp37m, which conflicts with any installable versions previously reported;
   ├─ xarray [0.7.2|0.8.0|...|0.9.1] would require
   │  └─ python_abi * *_cp34m, which conflicts with any installable versions previously reported;
   ├─ xarray [0.12.0|0.12.1|0.12.2|0.12.3|0.13.0] would require
   │  └─ pandas >=0.19.2,<2a0 , which conflicts with any installable versions previously reported;
   ├─ xarray [0.14.0|0.14.1] would require
   │  └─ pandas >=0.24,<2a0 , which conflicts with any installable versions previously reported;
   ├─ xarray [0.15.0|0.15.1|...|0.19.0] would require
   │  └─ pandas >=0.25,<2a0 , which conflicts with any installable versions previously reported;
   ├─ xarray 0.19.0 would require
   │  └─ pandas >=1.0,<2a0 , which conflicts with any installable versions previously reported;
   ├─ xarray [0.20.0|0.20.1|...|2022.6.0] would require
   │  └─ pandas >=1.1,<2a0 , which conflicts with any installable versions previously reported;
   ├─ xarray [2022.10.0|2022.11.0|2022.12.0] would require
   │  └─ pandas >=1.3,<2a0 , which conflicts with any installable versions previously reported;
   └─ xarray [2022.6.0|2022.9.0] would require
      └─ pandas >=1.2,<2a0 , which conflicts with any installable versions previously reported.

seems like with enough patching, things work out....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants