-
-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starting docs #95
Merged
+47
−0
Merged
Starting docs #95
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8d32805
docs: Create the documents directory and start by adding the guidelines.
jakirkham 134cfbf
guidelines: Drop vagrant sentence.
jakirkham 817e2f0
guidelines: Clean up indentation.
jakirkham 943894f
guidelines: Fix how to note people's wishes and where.
jakirkham 363353f
guidelines: Now it is a doc and not an issue.
jakirkham 2a508a0
guidelines: Remove duplicate paragraph.
jakirkham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
This document intends to layout some guidelines on the transfer of | ||
[conda-recipes]( https://github.com/conda/conda-recipes ) and | ||
[anaconda-recipes]( https://github.com/ContinuumIO/anaconda-recipes ) to | ||
conda-forge. These aren't hard and fast rules. They are certainly up for | ||
discussion. However, it would be good to come up with a consensus going forward. | ||
|
||
Eventually all recipes from those repos should be proposed for addition here. | ||
It may be decided that a few don't actually belong or should not be supported | ||
anymore. | ||
|
||
When adding a package from either location, inspect the commit history to see | ||
who has made changes to the recipe in the past. Anyone who has touched the recipe | ||
should be pinged about it getting added here. They should also be consulted with | ||
regards to whether the recipe needs any tweaks before being added. Also, they | ||
should be asked if they would like to be added as maintainers. Only if they give | ||
express permission to be adding as a maintainer should they be added to the | ||
maintainer list. In all cases when porting a recipe, you should add yourself as a | ||
maintainer. Some contributors to these repos were quite prolific, but may not be | ||
as actively engaged. If they specify they only want to be contacted for certain | ||
recipes or none at all, please respect their wishes also add make note of what | ||
recipes (if any) they would like to be notified for. If they are no longer | ||
interested in any conda recipes, make that note here as well. Before contacting | ||
anyone please consult the list in this | ||
[issue]( https://github.com/conda-forge/staged-recipes/issues/139 ) | ||
to see if that contributor has restrictions. | ||
|
||
When porting make sure the recipe follows the linting specifications. The | ||
section order should go `package`, `source`, `build`, `requirements`, `test`, | ||
`about`, `extra/recipe-maintainers`. It is recommended to add a `build` section | ||
with the `number` set to `0` explicitly even if the rest is unneeded. If there | ||
is no build for Windows, make sure to add `skip: True # [win]` to the `build` | ||
section. The `about` section must have the `home` URL (verify the URL is still | ||
correct), `license` (verify the correct license is present), and a one sentence | ||
(or few word) `summary`. When specifying the version it is strongly recommend | ||
that jinja templating be used to set the version at the top (e.g. `{% set | ||
version = "0.10.1" %}`) and then replace all uses of the version with `{{ | ||
version }}`. Preference should be given to compressed source balls as opposed to | ||
version control checkouts. Make sure all links to compressed source balls allow | ||
for easy changing of the version (using latest is not acceptable). Also, a | ||
checksum should be included with all compressed source balls to allow for | ||
verification of downloads. | ||
|
||
When adding a package from either location, inspect the commit history to see | ||
who has made changes to the recipe in the past. Anyone who has touched the | ||
recipe should be pinged about it getting added here. They should also be | ||
consulted with regards to whether the recipe needs any tweaks before being added. | ||
Also, they should be asked if they would like to be added as maintainers. Only if | ||
they give express permission to be adding as a maintainer should they be added to | ||
the maintainer list. In all cases when porting a recipe, you should add yourself | ||
as a maintainer. Some contributors to these repos were quite prolific, but may | ||
not be as actively engaged. If they specify they only want to be contacted for | ||
certain recipes or none at all, please respect their wishes also add here what | ||
recipes (if any) they would like to be notified for. If they are no longer | ||
interested in any conda recipes, make that note here as well. Before contacting | ||
anyone please consult the list below to see if that contributor has | ||
restrictions. | ||
|
||
It is required to add tests with all packages. These can included but are not | ||
limited to checking libraries are installed, python imports, simple code snippet | ||
to compile or run a basic test, command line usage (checking help or version). | ||
It is suggested that compiled code run all tests (e.g. `make check`) to ensure | ||
it was built properly. This normally should happen in the build. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entire paragraph seems like a duplicate of the two paragraphs before this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. That probably happened when I was trying to line wrap things. Will take a look. Thanks @ericdill.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed. Doesn't look like there was anything suppose to be in its place.