Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rerenders: do not raise on validation errors #1885

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Rerenders: do not raise on validation errors #1885

merged 3 commits into from
Mar 22, 2024

Conversation

jaimergp
Copy link
Member

@jaimergp jaimergp commented Mar 22, 2024 •
edited
Loading

Checklist

  • Added a news entry

Closes #1879

For now it doesn't offer any configuration options, and just replaces the previous errors with warnings formatted like this:

WARNING  conda_smithy.configure_feedstock:configure_feedstock.py:2002 conda-forge.yml: $.noarch_platforms = ['eniac', 'zx80'] -> ['eniac', 'zx80'] is not valid under any of the given schemas

Let me know if you want to have an option in the CLI, but for now users could just run recipe-lint before or after 🤷

@jaimergp jaimergp requested a review from a team as a code owner March 22, 2024 08:36
@beckermr beckermr merged commit dea900a into conda-forge:main Mar 22, 2024
2 checks passed
@ytausch ytausch mentioned this pull request Mar 25, 2024
Closed
@ytausch
Copy link
Contributor

ytausch commented Mar 25, 2024 •
edited
Loading

Please don't use logger.warn, as it's deprecated. Your IDE should be configured to display warnings like these.

#1865 will change it to warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckermr beckermr beckermr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

optionally make schema validation errors a warning instead of erroring out during rerenders
3 participants
@jaimergp @ytausch @beckermr