Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure MACOSX_SDK_VERSION is at least c_stdlib_version #1928

Merged
merged 1 commit into from
May 13, 2024
Merged

ensure MACOSX_SDK_VERSION is at least c_stdlib_version #1928

merged 1 commit into from
May 13, 2024

Conversation

h-vetinari
Copy link
Member

Fixes #1927 (minus the linter)

@h-vetinari h-vetinari requested a review from a team as a code owner May 12, 2024 22:50
@h-vetinari h-vetinari mentioned this pull request May 12, 2024
Closed
@h-vetinari
Copy link
Member Author

Note that the current state of this PR will end up populating MACOSX_SDK_VERSION everywhere, but with a matching version to whatever we get after merging c_stdlib_version / MACOSX_DEPLOYMENT_TARGET. If we want to avoid that, I can change the logic here to only add MACOSX_SDK_VERSION if it is different. But I don't really see how it would hurt to have it in the variant configs.

CC @beckermr @isuruf

@h-vetinari h-vetinari mentioned this pull request May 12, 2024
Open
57 tasks
@beckermr beckermr merged commit 59aa8df into conda-forge:main May 13, 2024
2 checks passed
@h-vetinari h-vetinari deleted the sdk branch May 13, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckermr beckermr beckermr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: MACOSX_SDK_VERSION not participating in merge logic
2 participants
@h-vetinari @beckermr