Extend azure.free_disk_space to Windows as well
#1966
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 28, 2024
jakirkham
force-pushed
the
azure_win_cleanup
branch
3 times, most recently
from
32ed6d4
to
2df379e
Compare
|
👍 Xref #1949, which also contains a work-around. |
|
Thanks Axel! 🙏 Was finding the deletion time on Azure to be pretty slow. Tried every trick I could think of with If you know of better ways to delete on Windows, please let me know Agree changing the build directory path is worth considering |
This was referenced Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to Linux, enable
azure.free_disk_spaceon Windows. This helps free up some space in cases where it is needed. Also it can fix build issues where a system Python is accidentally pulled into builds causing hard to diagnose issues.Also switch Miniforge downloads to use PowerShell. This removes the reliance on the system Python for this step (making the aforementioned cleanup possibly). Additionally it slims the step down a bit and makes it a bit easier to parse.
Checklist
newsentry