-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure $MINIFORGE_HOME exists during osx build #2142
Conversation
For the record, the failure happens at https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1085096&view=logs&j=7df89df7-19f1-5ccc-b210-32c1d05c0f56&t=c5e4c004-2534-57b9-b739-c5013de31afa
|
I am now seeing a new issue where
|
Let's merge this pr and then make a new issue+pr for the validation stuff. |
@@ -8,6 +8,8 @@ set -xe | |||
|
|||
MINIFORGE_HOME=${MINIFORGE_HOME:-${HOME}/miniforge3} | |||
MINIFORGE_HOME=${MINIFORGE_HOME%/} # remove trailing slash | |||
mkdir -p ${MINIFORGE_HOME} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work with Miniforge however
The following...
mkdir tst_mf_home_already_present
bash ~/Downloads/Miniforge3-24.9.0-0-MacOSX-arm64.sh -b -p tst_mf_home_already_present
...gives this error...
ERROR: File or directory already exists: 'tst_mf_home_already_present'
If you want to update an existing installation, use the -u option.
Think this should be moved into the pixi block instead or we add -u
to the Miniforge command
Edit: Micromamba would likely have the same issue
I can't revert from my phone but feel free to go ahead. Otherwise I can do it later. |
Let's just fix it instead of reverting as it is a one line change: #2146 Was mentioning in case we were planning to release soon. Think we should hold off until it is confirmed fixed |
Checklist
news
entrypython conda_smithy/schema.py
)I noticed this issue when using pixi as conda install tool. The
mkdir
command is outside the pixi condition but I can also move it inside it if you prefer. Let me know.