Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to install ATL components #2143

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Nov 19, 2024

Fixes #2062

This breaks on only a handful of feedstocks, but where it does happen it's very annoying to fix for every rerender (and non-obvious for those who don't know). Initially my hope was that MSFT would solve actions/runner-images#9873, but after many months, it's time to admit that that won't happen.

@h-vetinari h-vetinari requested a review from a team as a code owner November 19, 2024 21:08
Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I assume you have tested in feedstock? Assuming it works there, let's merge!

@jakirkham
Copy link
Member

Will we want this on GHA too?

@h-vetinari
Copy link
Member Author

LGTM! I assume you have tested in feedstock? Assuming it works there, let's merge!

Have tested this successfully on llvmdev (an affected feedstock). :)

Will we want this on GHA too?

I don't think this is relevant unless/until we start building such big packages on GHA. Also, the setting is currently under AzureRunnerSettings, so that also wouldn't make much sense for GHA. Let's add it when it becomes a concern.

@h-vetinari
Copy link
Member Author

h-vetinari commented Nov 20, 2024

Hm, I had tested the rerender, but not in CI yet. The current version of this PR ends up producing

jobs:
- job: win
  install_atl: true
  pool:
    vmImage: windows-2022

which azure stumbles over with:

/.azure-pipelines/azure-pipelines-win.yml (Line: 7, Col: 3): Unexpected value 'install_atl'

@h-vetinari
Copy link
Member Author

OK, as of the last commit, this is fixed now (i.e. CI for conda-forge/llvmdev-feedstock@54733d3 is running fine).

@h-vetinari h-vetinari merged commit ff5e3a4 into conda-forge:main Nov 20, 2024
2 checks passed
@h-vetinari h-vetinari deleted the atl branch November 20, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add azure option to install atl on Windows
3 participants