fix: need pinnings for register ci too #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@conda-forge/core this PR is ready to go! This one is blocking staged recipes, so it'd be good to merge asap. |
13 tasks
h-vetinari
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Presumably this is coming from this thread. Thanks for the quick fix!
It definitely makes sense IMO that we pick up our own pinning file when register-ci is called for feedstock-creation (might also make sense in wider circumstances, but don't know this part of the code very well, so hard to say).
Fine to move forward like this from my POV!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
newsentrypython conda_smithy/schema.py)This PR fixes a bug that is blocking staged-recipes. The value of
python_minis needed in order to get the recipe name in conda-build. I fixed a similar bug before, but missed this version of it.