Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix ignore_run_exports for v1 recipes #2157

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adament
Copy link

@adament adament commented Nov 21, 2024

The ignore_run_exports directive for v1 recipes has a different format, attempt to support it for the lint_single_space_in_pinned_requirements.

I only run the lint for the from_package section, should we also run it over the from_name section if that exists?

Should I also add a test-case with the recipe which failed?

Closes #2153

Checklist

  • Added a news entry
  • Regenerated schema JSON if schema altered (python conda_smithy/schema.py)

@adament adament requested a review from a team as a code owner November 21, 2024 18:36
The ignore_run_exports directive for v1 recipes has a different format,
attempt to support it for the lint_single_space_in_pinned_requirements.
Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a news item and a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linter fails on rattler-build recipe
2 participants