lower limit at which we start shortening filenames for variant configs #2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but don't just take the short_config_name, which is too short to distinguish the file names of the respective builds (e.g. CPU vs. CUDA)
isuruf
reviewed
Jan 27, 2025
| short_config_name = config_name[:35] + "_h" + h | ||
| if len("conda-forge-build-done-" + config_name) >= 250: | ||
| short_config_name = config_name[:40] + "_h" + salt | ||
| if len("conda-forge-build-done-" + config_name) >= 200: |
There was a problem hiding this comment.
Suggested change
| if len("conda-forge-build-done-" + config_name) >= 200: | |
| if len(config_name) >= 190: |
There was a problem hiding this comment.
Doesn't this need to take into account something like
C:\Users\runnerx\_work\pytorch-cpu-feedstock\pytorch-cpu-feedstock\.ci_support\
(not sure where you got that from, and why the pytorch-cpu-feedstock is doubled), then we can directly check >=260.
isuruf
reviewed
Jan 27, 2025
| @@ -791,12 +791,13 @@ def dump_subspace_config_files( | |||
| package_key(config, top_level_loop_vars, metas[0].config.subdir), | |||
| ) | |||
| short_config_name = config_name | |||
| salt = hashlib.sha256(config_name.encode("utf-8")).hexdigest()[:8] | |||
There was a problem hiding this comment.
Suggested change
| salt = hashlib.sha256(config_name.encode("utf-8")).hexdigest()[:8] | |
| hash = hashlib.sha256(config_name.encode("utf-8")).hexdigest()[:8] |
isuruf
reviewed
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was proposed by Isuru here. I don't know where the limit on the windows server from prefix is coming from, normally filenames until 260 characters should be fine, but it still fails in conda-forge/pytorch-cpu-feedstock#332 (which has been rerendered with the changes this PR) with
On the other hand, I don't want to shorten the config names too much, because then we lose a lot of information which is relevant for the pytorch/tensorflow feedstocks, like is this a CPU or GPU job (doubly so if we'd take the doubled CI as in conda-forge/pytorch-cpu-feedstock#332), and it's not desirable to just too-short filenames that are only distinguishable by hashes, where one has no idea which exact config is behind when looking at the actions UI.