Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for pypy #4

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update pypy.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children:

And potentially more.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/573518816, please use this URL for debugging

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@milesgranger
Copy link
Contributor

Would we rather want to use PYO3_PYTHON? https://pyo3.rs/v0.13.2/building_and_distribution/pypy.html
(coming from a PyPy noobie though.. 😅 )

@martindurant
Copy link

Huh, seems to have changed since the version I happened to be looking at https://pyo3.rs/v0.11.1/pypy.html . Maybe it's backward compatible - let's see what the build does.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [13, 14]

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@milesgranger
Copy link
Contributor

Wondering if pypy needs to be more manual, invoking something like PYO3_PYTHON={{ PYTHON }} maturin build --manylinux off --out wheels followed by the pip install.

@martindurant
Copy link

@milesgranger
I have no idea! This was shoot-and-hope.
You have write access to the bot's branch, so please have a go! Note that conda allows full build scripts to be included in the recipe directory.

@milesgranger
Copy link
Contributor

I'll poke at it this evening. 👌

@milesgranger
Copy link
Contributor

I'm out of reasonable attempts for now.

The logic of renaming the resulting wheels for PyPy stems from PyO3/maturin#312, as noted in my comment I can get this to install inside a docker container with PyPy and Rust, after using the post-build script (pypy_patch.py) here in the commits for renaming the PyPy wheel.

However, I'll guess there is something amiss with my attempts to run the said script; does it all have to be in bash.sh? Maybe you see something I don't.

And to clarify, it's not possible to just use the wheels on PyPi? Adding support for PyPy wheels seems maybe easier via GitHub actions. And we could just pull those wheels to be used in place of the build recipe we have here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants