-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cryptography v38.0.1 #104
cryptography v38.0.1 #104
Conversation
…nda-forge-pinning 2022.09.07.10.20.36
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please restart ci |
@h-vetinari @ocefpaf @jakirkham Any chance of fixing this? There are some packages waiting for this new version as dependencies |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/cryptography-feedstock/actions/runs/3150339477. |
Sorry this fell through the cracks. It's been far too low on my to-do list, but if we ever get to it, it would be good to just package the |
Ugh, completely useless error message...
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was not passing and not merged. |
Googling says that the But then ... why did this start happening relatively recently? (I'm also seeing this with conda-forge/tectonic-feedstock#55.) update: FWIW, in the most recent successful Windows build of Tectonic, update 2: Nothing in the conda-build 3.22 changelog sounds relevant to the change in behavior. Another potentially-important difference in the Tectonic feedstock is that setuptools jumps from 62.3.2 to 65.4.1. |
Hi! This is the friendly conda-forge automerge bot! Commits were made to this PR after the |
@@ -28,7 +28,7 @@ jobs: | |||
UPLOAD_PACKAGES: 'True' | |||
timeoutInMinutes: 360 | |||
variables: | |||
CONDA_BLD_PATH: D:\\bld\\ | |||
CONDA_BLD_PATH: C:\bld\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably won't work. I thought that the D:
use case was deep nested into subdirs :-/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to pin the version of setuptools used by the build process? My theory is that downgrading to 62.x might make the problem go away. Pinning here wouldn't be a real fix, of course, but it would be nice to be able to test the theory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can pin but yeah, ideally we should fix this for good. Trying that now...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pin I was thinking of would apply to the builder's environment — i.e. the Python process invoking conda-build, not the host environment of the package. I think maybe something changed in setuptools that caused conda-build to do the vcvars setup twice, leading to the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, did not pay enough attention to the issue. We can pin but that would be a bit disruptive. I'll hack the CIs here tomorrow to test if this fixes it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ocefpaf See below, no need — I think I was on the wrong trail anyway.
65b5cb3
to
40b737b
Compare
OK, well I sat down with a Windows VM, and it looks like my setuptools theory was wrong anyway. As far as I can tell, the double-invocation of I think this makes sense since
Is it appropriate to remove the |
Also, here is where the Rust activation script seems to get tied to vs2017, if it would be better to update that to vs2019. update: oh great, @h-vetinari I see that you are one of the experts on this. Reading conda-forge/conda-forge.github.io#1732 I get the strong impression that rust-activation should be updated to vs2019. Do you agree? update 2: I've gone ahead and filed a PR, conda-forge/rust-activation-feedstock#28 |
Yes that absolutely sounds like the right way to go! :) |
Thank you (both for the analysis & the PR)! :) Let's see if this feedstock is looking better again now! |
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.Closes: #103
Pending Dependency Version Updates
Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.
Dependency Analysis
Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add
bot: inspection: false
to yourconda-forge.yml
. If you encounter issues with this feature please ping the bot teamconda-forge/bot
.Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.
Packages found by source code inspection but not in the meta.yaml:
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3008460515, please use this URL for debugging.