Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CTK packages to {{ stdlib("c") }} #26

Closed
jakirkham opened this issue Apr 17, 2024 · 2 comments
Closed

Migrate CTK packages to {{ stdlib("c") }} #26

jakirkham opened this issue Apr 17, 2024 · 2 comments

Comments

@jakirkham
Copy link
Member

The sysroot* syntax used currently by CTK recipes is getting phased out

Sample syntax as seen currently in libcublas:

        - sysroot_{{ target_platform }} 2.17    # [linux]

The recommendation is to move to {{ stdlib("c") }} ( conda-forge/conda-forge.github.io#2102 )

The simplest way to make this change would be to add the following to conda-forge.yml files:

os_version:
  linux_64: cos7
  linux_aarch64: cos7
  linux_ppc64le: cos7

Make the following change to recipe/meta.yaml

-        - sysroot_{{ target_platform }} 2.17    # [linux]
+        - {{ stdlib("c") }}

Then re-render

@jakirkham jakirkham changed the title Migrate to {{ stdlib("c") }} Migrate CTK packages to {{ stdlib("c") }} Apr 17, 2024
@h-vetinari
Copy link
Member

The simplest way to make this change would be to add the following to conda-forge.yml files:

os_version:
  linux_64: cos7
  linux_aarch64: cos7
  linux_ppc64le: cos7

That change shouldn't be necessary for the stdlib-migration - if it ran fine before without setting os_version, it should work fine after adding replacing sysroot_{{ ... }} with {{ stdlib("c") }} and setting

c_stdlib_version:  # [linux]
 - "2.17"          # [linux]

in recipe/conda_build_config.yaml. The only reason (to my knowledge) where it'd be necessary to override os_version is if a newer glibc is required to actually execute things (e.g. testing the package, as our build deps generally don't require newer symbols so far).

@jakirkham
Copy link
Member Author

As the CTK packages already require 2.17, it seems reasonable to add os_version in this case

Agree that other cases may not need this

This was referenced Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants