-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for CUDA12.6.0 #24
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
|
…nda-forge-pinning 2024.08.02.08.34.06
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
|
…nda-forge-pinning 2024.08.02.08.34.06
@conda-forge-admin, please restart ci |
@conda-forge-admin, please restart ci |
@conda-forge-admin, please lint |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally. This message was generated by GitHub actions workflow run https://github.com/conda-forge/cuda-nvcc-impl-feedstock/actions/runs/10220814745. |
I've been hitting that rerender error as well, doing it locally does work though. |
The re-rendering is complaining it did not know how to define cuda-nvcc-impl-feedstock/recipe/meta.yaml Lines 7 to 9 in 938b371
|
What version of |
24.5.0 |
Ok so maybe this is a bug with the recently released Edit: Interesting that building the package doesn't run into this issue. Must have something to do with where |
Just to confirm, are you using |
Yes |
|
||
-TOP = $(_HERE_)/.. | ||
+TOP = $(_HERE_)/../$(_TARGET_DIR_) | ||
|
||
CICC_PATH = $(TOP)/nvvm/bin | ||
CICC_NEXT_PATH = $(TOP)/nvvm-next/bin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robertmaynard am assuming this is ok since this is dropped from the source file. We were not patching this line. Though please let us know if we need to change anything here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah missed Rob is out today. Think we should be ok here. So let's go ahead and merge
We can follow up with Rob when he get back
Pulled your changes and local rerender had no further changes, adding automerge. Thanks John! |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
Regarding the re-rendering issue, filed upstream issue: conda-forge/conda-smithy#2011 |
xref:
{{ stdlib("c") }}
cuda-feedstock#26