-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add target libraries/executables to executable's RPATH #17
Conversation
…nda-forge-pinning 2024.10.31.07.03.28
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Seeing the following warnings on CI
Both of those packages are there. So this suggests we might still be missing something with how the RPATH is set. So let's give this one another look |
cebc739
to
fd8f636
Compare
Pushed the fix. These missing DSO warnings are gone now after patching cuda-gdb file for aarch64. I was ignoring it because it was a shell script for linux-64, but didn't realize it is a binary executable for aarch64. Thanks. |
if [[ $i == "bin" ]]; then | ||
for j in `ls "${i}"`; do | ||
[[ -f "bin/${j}" ]] || continue | ||
[[ ${j} == "cuda-gdb" && ${target_platform} == "linux-64" ]] && continue # cuda-gdb is a shell script for linux-64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this Billy! 🙏
Just to clarify for anyone who reads this thread...
cuda-gdb
is a binary onlinux-aarch64
cuda-gdb
is a shell script onlinux-64
So we patch the former and skip the latter
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)conda-forge/cuda-feedstock#10