Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target libraries/executables to executable's RPATH #16

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

billysuh7
Copy link
Contributor

@billysuh7 billysuh7 commented Nov 4, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

xref: conda-forge/cuda-feedstock#10

There is only one DSO lib to patch, libnvidia-ml.so.
Also this file will have a symlink as shown below.

From $PREFIX/lib/stub/,

libnvidia-ml.so -> ../../targets/x86_64-linux/lib/stubs/libnvidia-ml.so*

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@billysuh7 billysuh7 marked this pull request as ready for review November 4, 2024 00:32
@billysuh7 billysuh7 requested a review from a team as a code owner November 4, 2024 00:32
@billysuh7 billysuh7 merged commit d912e25 into conda-forge:main Nov 4, 2024
6 checks passed
@billysuh7 billysuh7 deleted the topic/bsuh/rpath branch November 4, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants