Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch nvprof so it doesn't link outside the conda environment #12

Merged
merged 7 commits into from
Aug 6, 2024

Conversation

danpetry
Copy link
Contributor

@danpetry danpetry commented May 9, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

When overlinking check is turned on, the following error message occurs:

ERROR (cuda-nvprof,bin/nvprof): runpaths ['$ORIGIN/../extras/CUPTI/lib64', '$ORIGIN/../targets/x86_64-linux/lib'] found in
/croot/cuda-nvprof_1715204971555/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_plac
ehold_placehold_placehold_placehold_place/bin/nvprof"

xref: conda-forge/cuda-feedstock#10

@danpetry danpetry requested a review from a team as a code owner May 9, 2024 21:23
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [29]

For recipe:

@danpetry danpetry force-pushed the dpetry/patch-nvprof branch from 9cf64ec to 3044190 Compare May 9, 2024 21:34
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@danpetry
Copy link
Contributor Author

danpetry commented May 9, 2024

@conda-forge-admin, please rerender

@danpetry
Copy link
Contributor Author

@bdice @jakirkham

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me. I'll add automerge so this can merge once CI passes.

@bdice bdice added the automerge Merge the PR when CI passes label Aug 6, 2024
@github-actions github-actions bot merged commit d1990b8 into conda-forge:main Aug 6, 2024
4 checks passed
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@danpetry danpetry deleted the dpetry/patch-nvprof branch August 6, 2024 21:21
@danpetry
Copy link
Contributor Author

danpetry commented Aug 6, 2024

great, thanks.

@jakirkham
Copy link
Member

Thanks all! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants