Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverse symlinks #3

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

reverse symlinks #3

wants to merge 6 commits into from

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Nov 14, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Fixes #2

cc @peterbell10

@isuruf isuruf requested a review from adibbley as a code owner November 14, 2023 21:55
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@isuruf isuruf mentioned this pull request Nov 15, 2023
1 task
recipe/meta.yaml Outdated

outputs:
- name: cuda-nvtx
build:
skip: true # [not linux]
files:
- lib/libnv*.so.* # [linux]
- targets/{{ target_name }}/lib/*.so.* # [linux]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved these to the dev package, but I'm not even sure if these are needed at all.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting given we already have these here and other packages have already built against cuda-nvtx, am a little hesitant to remove something that packages in user environments may already be depending on

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted for now

@jakirkham
Copy link
Member

Thanks for putting this together Isuru! 🙏

Would it be possible to configure CI to cache the packages so we can download them and do some tests? Maybe using azure/store_build_artifacts?

@isuruf
Copy link
Member Author

isuruf commented Nov 16, 2023

@conda-forge-admin, rerender

conda-forge-webservices[bot] and others added 4 commits November 16, 2023 15:39
@isuruf
Copy link
Member Author

isuruf commented Nov 17, 2023

@isuruf
Copy link
Member Author

isuruf commented Nov 21, 2023

Ping on this

@jakirkham
Copy link
Member

Thanks Isuru! 🙏

Appreciate the reminder

Quoting @msarahan's recent reply ( #2 (comment) ):

We've been discussing this extensively internally and we definitely think it's a big issue, as it could affect CUDA libraries other than NVTX. The team is working on a document that details possible solutions in the context of CUDA library packages that exist in other forms. We'll file an issue in https://github.com/conda-forge/cuda-feedstock with more info when we've dug in more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RPATHs are wrong.
2 participants