-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reverse symlinks #3
base: main
Are you sure you want to change the base?
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
recipe/meta.yaml
Outdated
|
||
outputs: | ||
- name: cuda-nvtx | ||
build: | ||
skip: true # [not linux] | ||
files: | ||
- lib/libnv*.so.* # [linux] | ||
- targets/{{ target_name }}/lib/*.so.* # [linux] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved these to the dev package, but I'm not even sure if these are needed at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting given we already have these here and other packages have already built against cuda-nvtx
, am a little hesitant to remove something that packages in user environments may already be depending on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted for now
Thanks for putting this together Isuru! 🙏 Would it be possible to configure CI to cache the packages so we can download them and do some tests? Maybe using |
@conda-forge-admin, rerender |
…nda-forge-pinning 2023.11.16.09.46.51
Ping on this |
Thanks Isuru! 🙏 Appreciate the reminder Quoting @msarahan's recent reply ( #2 (comment) ):
|
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Fixes #2
cc @peterbell10