Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cython 0.29.31 #94

Closed
wants to merge 4 commits into from
Closed

cython 0.29.31 #94

wants to merge 4 commits into from

Conversation

h-vetinari
Copy link
Member

Not sure what the bot is stuck on again, but this release has been much-awaited, so let's build it.

Also proposing to add myself to maintainers here, if no-one objects.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member

jakirkham commented Jul 28, 2022

From CI looks like the sdist can't be downloaded (likely the same reason the bot hasn't issued a PR)

An HTTP error occurred when trying to retrieve this URL.
HTTP errors are often intermittent, and a simple retry will get you on your way.
WARNING:conda_build.source:Error: HTTP 404 NOT FOUND for url <[https://pypi.io/packages/source/C/Cython/Cython-0.29.31.tar.gz>](https://pypi.io/packages/source/C/Cython/Cython-0.29.31.tar.gz%3E)
Elapsed: 00:00.280736

Looks similar to other PyPI CDN issues we've seen recently ( pypi/infra#104 ). It is worth noting these are getting fixed, but this maybe an edge case (perhaps due to the capitalization).

Edit: Mentioned in comment ( pypi/infra#104 )

@h-vetinari
Copy link
Member Author

@jakirkham
Seems we saw the same error but chose to follow different approaches to tackle it. 🙃

I tend to prefer GH sources in most cases, not least because it's faster & more direct, but because it also removes a potential injection vector through sources on PyPI being different than on github (not that any of the big packages are at serious risk there, but still...)

From that POV, this PR should be ready.

PS. I'd be very thankful if you could have a quick look at my PR on the openssl feedstock, if you have a moment. :)

@ocefpaf
Copy link
Member

ocefpaf commented Jul 28, 2022

I'm also +1 for GH sources but, python packaging is such a mess, that in some cases the "injection" is official and there are missing parts in teh GH tarball. This is not the case I'm OK with the changes here. If we have one more +1 we can merge it.

@jakirkham
Copy link
Member

Appreciate the effort Axel.

It appears PyPI has resolved this issue. Recently the bot came by and added PR ( #95 ), which seems to work and has been merged.

@h-vetinari
Copy link
Member Author

Appreciate the effort Axel.

Then why merge that other PR? This one was technically superior, faster, and would have added a maintainer (me). I don't assume it was intentional, but it certainly doesn't give me a warm and fuzzy feeling about (re)trying to join this feedstock.

@h-vetinari h-vetinari closed this Jul 29, 2022
@h-vetinari h-vetinari deleted the bump branch July 29, 2022 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants