-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cython 0.29.31 #94
cython 0.29.31 #94
Conversation
…nda-forge-pinning 2022.07.28.00.27.46
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
From CI looks like the
Looks similar to other PyPI CDN issues we've seen recently ( pypi/infra#104 ). It is worth noting these are getting fixed, but this maybe an edge case (perhaps due to the capitalization). Edit: Mentioned in comment ( pypi/infra#104 ) |
@jakirkham I tend to prefer GH sources in most cases, not least because it's faster & more direct, but because it also removes a potential injection vector through sources on PyPI being different than on github (not that any of the big packages are at serious risk there, but still...) From that POV, this PR should be ready. PS. I'd be very thankful if you could have a quick look at my PR on the openssl feedstock, if you have a moment. :) |
I'm also +1 for GH sources but, python packaging is such a mess, that in some cases the "injection" is official and there are missing parts in teh GH tarball. This is not the case I'm OK with the changes here. If we have one more +1 we can merge it. |
Appreciate the effort Axel. It appears PyPI has resolved this issue. Recently the bot came by and added PR ( #95 ), which seems to work and has been merged. |
Then why merge that other PR? This one was technically superior, faster, and would have added a maintainer (me). I don't assume it was intentional, but it certainly doesn't give me a warm and fuzzy feeling about (re)trying to join this feedstock. |
Not sure what the bot is stuck on again, but this release has been much-awaited, so let's build it.
Also proposing to add myself to maintainers here, if no-one objects.