Set HDF5_ROOT to avoid hardcoding library dependencies #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulromano
requested review from
bam241,
gonuke,
kkiesling,
ljacobson64,
ngranda,
pshriwise and
shimwell
as code owners
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2023.12.04.19.29.31
gonuke
requested changes
Dec 5, 2023
| @@ -32,6 +32,9 @@ cmake -DBUILD_MCNP5=OFF \ | |||
| -DBUILD_PIC=OFF \ | |||
| -DBUILD_RPATH=ON \ | |||
| -DDOUBLE_DOWN=OFF \ | |||
| -DCMAKE_POLICY_DEFAULT_CMP0074=NEW \ | |||
| -DHDF5_ROOT="${PREFIX}" \ | |||
| -DHDF5_FIND_DEBUG=ON \ | |||
There was a problem hiding this comment.
Does this have a continuing purpose? Or was it transient?
There was a problem hiding this comment.
Just debugging, although the fix I've proposed here didn't work as intended so I still have some digging to do 😞
|
Well, unfortunately my attempts to get around the HDF5 library linking issue appear to be unsuccessful. I'm going to submit a PR to DAGMC proper that can be incorporated in a future release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the DAGMC package on conda forge has hardcoded libraries in the exported
DAGMCTargets.cmakefile from a temporary build path which won't show up on a user's system, which breaks downstream dependencies (e.g., OpenMC). After a lot of digging, I've determined that it is the fault of HDF5. See here for a detailed explanation: InsightSoftwareConsortium/ITK#343.The solution in the above linked ITK issue is to change how HDF5 is linked by using
*_LIBRARY_NAMESrather than*_LIBRARIES. An easier workaround that requires no changes in the DAGMC source itself is to setHDF5_ROOT, which causesh5cc -showto fail which then triggers a fallback in FindHDF5.cmake whereby it only searches for libhdf5.so and not all the transitive dependencies.I'm not sure there's a good proper fix short of 1) the HDF5 feedstock on conda-forge using CMake rather than autoconf, or 2) FindHDF5.cmake being fixed to not hardcode paths to system libraries.
Checklist
Reset the build number to0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)