-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to build with or without doubledown #30
base: main
Are you sure you want to change the base?
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendering locally. This message was generated by GitHub actions workflow run https://github.com/conda-forge/dagmc-feedstock/actions/runs/11077696903. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
It would be great to include doubledown I thought it was not available on conda so that might need fixing first. Here is the related issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it needs more help to find double down
@@ -31,7 +48,6 @@ cmake -DBUILD_MCNP5=OFF \ | |||
-DBUILD_STATIC_EXE=OFF \ | |||
-DBUILD_PIC=OFF \ | |||
-DBUILD_RPATH=ON \ | |||
-DDOUBLE_DOWN=OFF \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to specify the location of double down:
-Ddd_ROOT=${PREFIX} && \
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.10.04.13.32.50
After specifying the location of double down and rerendering the feedstock since I changed the name of the double down variable to |
When I look at the tests, I don't see any evidence that this was built with double down. I think it's because it's using v3.2.3 and the CMake configuration is out of date relative to |
@gonuke, @bquan0 and I touched base this morning. As a short term solution I suggested verbose output from one of the tests which will show whether or not double down is enabled in the output:
In the long term, for partial verification we certainly should add some output from DAGMC that double down is enabled during the configuration step. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)I added a variable in
conda_build_config.yaml
fordoubledown
and modifiedbuild.sh
andmeta.yaml
to allow packages to be built with or withoutdoubledown
.