-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new CLI commands #225
Add new CLI commands #225
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
# New CLI added in https://github.com/dask/distributed/pull/6735 | ||
- dask scheduler = distributed.cli.dask_scheduler:main | ||
- dask ssh = distributed.cli.dask_ssh:main | ||
- dask worker = distributed.cli.dask_worker:main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idk if doing this with a space works as expected. What happens here is a binary is created that has a space in its name. For example...
$ which "dask scheduler"
/Users/jkirkham/miniforge/envs/dask/bin/dask scheduler
Though this isn't the same as...
$ which dask
/Users/jkirkham/miniforge/envs/dask/bin/dask
...or...
$ which dask scheduler
/Users/jkirkham/miniforge/envs/dask/bin/dask
scheduler not found
Should add dask scheduler
with a space doesn't seem to work correctly either...
dask scheduler --help
Usage: dask [OPTIONS] COMMAND [ARGS]...
Try 'dask -h' for help.
Error: No such command 'scheduler'.
So there is still some work needed here (Idk what atm).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, shoot -- thanks for looking into this @jakirkham. It this a bit strange as this change appeared to fix related failing CI builds over in distributed
. Regardless, I'm able to reproduce dask scheduler
not working when I install the latest dask
builds in a fresh conda
environment:
$ mamba create -n test python=3.10 dask=2022.10.0
$ dask scheduler
Usage: dask [OPTIONS] COMMAND [ARGS]...
Try 'dask -h' for help.
Error: No such command 'scheduler'.
A couple of additional observations:
- This appears to be a
conda
-specific thing. When I usepip
to install a the latestdask
+distributed
in a fresh environment,dask scheduler
exists and works as expected. This makes me think that all theentry_points
/console_scripts
logic is set up correctly. - I intentionally added tests for
dask scheduler
/dask worker
/dask ssh
in this PR that passed in CI. That makes this extra confusing.
@jakirkham do you have any thoughts on how we might be able to further debug here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The relevant entrypoint in distributed
is defined here. Note that they're not console_scripts
entrypoints, but are instead using the new dask_cli
entrypoint. In this section of the conda-forge
docs, it says:
Only console_scripts entry points have to be listed in meta.yaml. Other entry points do not conflict with noarch and therefore do not require extra treatment.
Based on that, I agree we don't need to include entries for these entrypoints in the recipe here. We included the changes in this PR and over in the dask
feedstock at the same time. Based on these docs, maybe only the dask
feedstock changes were needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying that out in #226
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about this more, maybe we should try dropping the entrypoint from dask
as well. Perhaps that fixes the issue?
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)