-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate cos7 and alma8 docker files #287
Conversation
@conda-forge/core, this is ready |
When it comes to distributions, think it is better to keep them in separate For example this is now adding CentOS 7 repos to Alma, which don't make sense there. Plus the naming of the directories is confusing If the goal is simply to consolidate more content, would suggest taking the |
We are not. The fix_rpm uses those repos only for centos7. We would have to add alma8 repos there in the future as well. This PR reduces code duplication and the only thing that this PR does more is to copy centos7 repos and delete them without using them in alma8 which is okay IMO. |
Also, it looks like there's a single Dockerfile for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the deduplication. Also, both images are RHEL-derivatives, so a lot is the same, and the differences are small enough that unification is beneficial IMO.
@jakirkham let me know if there are any other objections. |
As a great illustration why this PR is beneficial, the addition of alma9-based images becomes absolutely trivial. |
Ping @jakirkham |
@jakirkham, it's been 3 weeks since you requested changes here. Please either engage in the discussion or lift your objection. It's completely fine to disagree, but blocking something and then not responding anymore is not OK.1 Let's please figure out what our respective concerns / constraints are, and find a mutually satisfactory solution. Footnotes
|
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)