-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix default info path #64
base: main
Are you sure you want to change the base?
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin please rerender |
…nda-forge-pinning 2022.07.12.02.03.03
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one comment. Feel free to ignore it. Otherwise nice work, thanks!
|
||
if [ "$(uname)" == "Linux" ]; then | ||
mkdir -p $PREFIX/share/emacs/site-lisp | ||
cat <<EOF > $PREFIX/share/emacs/site-lisp/site-start.el |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel a bit uneasy about this potentially overwriting an existing file. Would you mind adding a test for existence and/or use >>
to append instead of overwriting in that case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is supposed to be created by site administrators, it is not included with emacs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but it's possible that it will be introduced in other parts of the packaging in the future, and adding another >
seems like a trivial thing that wouldn't hurt much. But as I said, feel free to ignore. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
>>
would do nothing. This is done at the build step. Whatever file is created in the build is what is shipped with the package. If this file is somehow included with other packages and we want to append it, that will have to be done in a post-install script. Although I'm unclear what other packages would ship files in $PREFIX/share/emacs
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, let's forget about this comment.
We don't know why this happens in the first place? Presumably wherever this path is stored is using a fixed length string instead of a NULL-terminated string. At any rate we should include a comment to indicate that we should check if this is still needed whenever new versions are released. |
Oh I didn't see #60 (comment). So a more complete fix might require somehow making the conda-build binary string patching do the right thing for lisp strings, or patching |
Yes, but I think perhaps the problem is that |
Where is the string actually stored in the package? |
Unfortunately, this PR does not seem to fix the problem. It improves the situation because it fixes the path earlier than if you put it in your The other thing that puzzles me is that this |
Can you provide reproduction steps for this?
I'm not really sure, I assumed it happened at build time but I don't know why I thought that. |
I simply put the
|
Can you test by installing from the |
I tried installing from |
I definitely can't reproduce that. Does it happen with |
Oh, there is a bug though, hang on while I fix it. |
Well, after digging into a bit more I do see the problem you're talking about @zklaus . Indeed it seems that In my tests it does seem that setting |
Here is another idea: We could patch this snippet directly into |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Fixes #60