Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: flit 2.0 #17

Closed
wants to merge 9 commits into from
Closed

WIP: flit 2.0 #17

wants to merge 9 commits into from

Conversation

takluyver
Copy link
Contributor

Follows discussion on PR #15.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'outputs', 'about', 'extra'].

For recipe:

  • It looks like the 'flit-core' output doesn't have any tests.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'flit-core' output doesn't have any tests.

@takluyver
Copy link
Contributor Author

This is currently failing because pip can't bootstrap flit_core (I'm fixing that in pypa/pip#7394).

Maybe when I'm more awake I'll see a way around that. Otherwise, we'll either have to wait for a release of pip with that fix, or make a conda package of pep517 (which provides a minimal/proof of concept frontend which can bootstrap it).

@takluyver
Copy link
Contributor Author

The important bit of the error now looks to be:

INFO conda_build.build:build(1571): Packaging flit
Packaging flit
/home/conda/feedstock_root/build_artifacts/flit_1574762454456/work/install-flit.sh: line 4: /home/conda/feedstock_root/build_artifacts/flit_1574762454456/_h_env_placehold_...placehold_placeh/bin/python: No such file or directory

@ocefpaf ocefpaf mentioned this pull request Nov 26, 2019
3 tasks
@ocefpaf
Copy link
Member

ocefpaf commented Nov 26, 2019

Locally this is failing for me with:

Fetching list of valid trove classifiers               I-flit.validate
The file description seems not to be valid rst for PyPI; it will be interpreted as plain text  E-flit.validate
<string>:25: (WARNING/2) Cannot analyze code. Pygments package not found.
  E-flit.validate
Invalid config values (see log)

run:
- python
- pytoml
test:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indent here looks wrong to me. This should not be in requirements I think.


package:
name: flit
name: flit-split
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's my understanding that this will create a flit-split metapackage. Is that what you intended here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in this case. The name is ignored in this case as it isn't mentioned in outputs.

A better way of working around this conda-build "feature" is to use the name of the first output (flit-core in this case).

@chrisburr
Copy link
Member

I'm about to push a tidied version of this PR that I made while testing the fix for #17 (comment).

Comment on lines 14 to 15
entry_points:
- flit = flit:main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure, but I would assume that the entrypoints also need to go into the corresponding output section.

@saraedum
Copy link
Member

Locally this is failing for me with:

Fetching list of valid trove classifiers               I-flit.validate
The file description seems not to be valid rst for PyPI; it will be interpreted as plain text  E-flit.validate
<string>:25: (WARNING/2) Cannot analyze code. Pygments package not found.
  E-flit.validate
Invalid config values (see log)

Adding pygments as a requirement of the flit output fixes this for me. The buid then works for me with the above changes. It's a bit odd since this says "warning".

@takluyver
Copy link
Contributor Author

The pygments thing is pypa/flit#297

@takluyver
Copy link
Contributor Author

Thanks everyone for jumping in on this. I'll close this PR in favour of #19.

@takluyver takluyver closed this Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants