-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: flit 2.0 #17
WIP: flit 2.0 #17
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
This is currently failing because pip can't bootstrap flit_core (I'm fixing that in pypa/pip#7394). Maybe when I'm more awake I'll see a way around that. Otherwise, we'll either have to wait for a release of pip with that fix, or make a conda package of pep517 (which provides a minimal/proof of concept frontend which can bootstrap it). |
The important bit of the error now looks to be:
|
Locally this is failing for me with:
|
run: | ||
- python | ||
- pytoml | ||
test: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indent here looks wrong to me. This should not be in requirements
I think.
|
||
package: | ||
name: flit | ||
name: flit-split |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's my understanding that this will create a flit-split
metapackage. Is that what you intended here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not in this case. The name is ignored in this case as it isn't mentioned in outputs
.
A better way of working around this conda-build "feature" is to use the name of the first output (flit-core
in this case).
I'm about to push a tidied version of this PR that I made while testing the fix for #17 (comment). |
entry_points: | ||
- flit = flit:main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure, but I would assume that the entrypoints also need to go into the corresponding output section.
Adding pygments as a requirement of the flit output fixes this for me. The buid then works for me with the above changes. It's a bit odd since this says "warning". |
The pygments thing is pypa/flit#297 |
Thanks everyone for jumping in on this. I'll close this PR in favour of #19. |
Follows discussion on PR #15.