Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address some recipe issues in dependencies #10

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

jaimergp
Copy link
Member

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Closes #9

I fixed and merged the two cloudpickle entries. I don't see a good reason for having cloudpickle in run and then cloudpickle >=X,<Y in run_constrained. Also the greenlet * looks superfluous.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@tcompa
Copy link
Contributor

tcompa commented Oct 30, 2023

Hi there, and thanks a lot for your contribution!

The missing comma is now also being fixed in fractal-analytics-platform/fractal-server#937.

Also the greenlet * looks superfluous.

Agreed. This was recently addressed (fractal-analytics-platform/fractal-server#895), but that PR is not part of a release yet.

@tcompa
Copy link
Contributor

tcompa commented Oct 30, 2023

I fixed and merged the two cloudpickle entries. I don't see a good reason for having cloudpickle in run and then cloudpickle >=X,<Y in run_constrained.

This is probably due to a glitch somewhere in our dependency definition, or we got it wrong when we created the feedstock. The PyPI package comes with a set of extras (e.g. fractal-server[slurm]), and we have not yet explored the best way to include them in the conda package. For the moment they just appear in the run_constrained section.

cloudpickle is one of those dependencies, as it is only required when the slurm extra is present. Thus it is not a core (that is, run) requirement, and it should only be listed in the run_constrained section. Could you please make this additional change?

It's not obvious to me why it ended up in the run section in the first place.

Copy link
Contributor

@tcompa tcompa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once again, thanks a lot!

@tcompa tcompa merged commit 15cdbb0 into conda-forge:main Oct 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing comma in run_constrained
2 participants