-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linux #11
Add linux #11
Conversation
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@traversaro this build almost works -- locally -- the gzserver seems to be fine. However, when I run
GDB only shows this:
So I am not sure if the segfault is the result of the JPEG struct size mismatch or something else. |
I am not sure as well, but that warning seems to be quite serious, at it seems to hint that there is an ABI mismatch of some kind, and at least it is a lead. I suspect that for some reason the conda Gazebo is loading some system library, instead of the conda one (or equivalently is loading the conda library, but it has been compiled for some reason against the system headers of some library). |
Hmm, I suspect that our copy of freeimage somehow compiles JPEG with a different config as e.g. QT? Also there is a HAVE_BOOLEAN setting in the jpeg header that selectes either bool or int for the boolean parameters which might be the cause for the size mismatch. I also tested the OGRE samples and they're fine. |
How is Qt compiled in conda-forge? To avoid this problems, qt is tipically compiled with the |
Unless I miss something, qt should use the indeed the system (in this case conda, I hope) libjpeg: https://github.com/conda-forge/qt-feedstock/blob/952b2000647b887c3bf23f4653aad36275a358ec/recipe/build.sh#L174 . |
Perhaps conda-forge/qt-main-feedstock#124 may be related? |
over on gitter @chrisburr suggested to remove |
yeah that might be it. I just checked all my libraries and none links to libjpeg (including the QT ones) (also doesn't link libpng). So maybe it's accidentally statically linked ... On my Fedora, those two libs link against libjpeg:
Here is the output of ldd on libQt5WebEngineCore from conda-forge:
Here is libgazebo_gui:
|
With a quick check, at least in libjpeg-turbo that message is actually a fatal error that exits the program:
Furthermore, at least on my machine Qt links libjpeg via the plugin
To check if jpeg is statically linked, probably you can just inspect the symbols contained in the library, in my case they are " U " i.e. undefined as jpeg is linked dynamically:
|
recipe/meta.yaml
Outdated
- qt | ||
- ogre | ||
- ogre 1.12.5 h6508522_2 # [linux] | ||
- ogre 1.12.5 # [win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wolfv @traversaro Curious about have you run into any problems on Linux with OGRE 1.12? (I mean at runtime.) At least from my testing, it seems Gazebo is not really OGRE 1.12 ready and there are more work to do to enable that. I am thinking we may want to downgrade it to 1.10 for now...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I remember, I did not run Gazebo with Ogre 1.12.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened a dedicated upstream issue to track this: https://bitbucket.org/osrf/gazebo/issues/2700/gazebo-11-does-not-run-correctly-with-ogre .
After 1 week of fighting I finally got here! Indeed I recompiled freeimage with external libjpeg and the same way of including it vs. Qt and it works! Now I got OGRE problems :D
|
I got it to work using ogre 1.10.12 🎉 Will need a PR to the feedstocks of freeimage and ogre to make gazebo work on cf :) |
For reference, this is the same error that @seanyen got on Conda on Windows, see https://bitbucket.org/osrf/gazebo/issues/2686/terrain-rendering-does-not-support-shadows and the related issue https://bitbucket.org/osrf/gazebo/issues/2700/gazebo-11-does-not-run-correctly-with-ogre . |
@seanyen this is ready now! :) |
recipe/meta.yaml
Outdated
|
||
build: | ||
number: 4 | ||
skip: true # [not win] | ||
number: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just increase the number to 5
and make the skip only on [not osx]
? (and can you make this pull request editable too? I can also help on the cleanup.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is gazebo 11 so I am not sure it will build on Windows, unfortunately, and since it's a completely new version number I changed the build number back to 0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, wait, you also have gazebo 11 🤦♂️
Then I will have to do your changes. sry about that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok let's hope this builds :)
…nda-forge-pinning 2020.03.10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)