Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Regression in Gazebo 11.10 on Windows #113

Merged
merged 7 commits into from
Jan 28, 2022

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Jan 28, 2022

Fix #112 by backporting gazebosim/gazebo-classic#3165 .

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro traversaro added the automerge Merge the PR when CI passes label Jan 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2022

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Jan 28, 2022
@traversaro traversaro added the automerge Merge the PR when CI passes label Jan 28, 2022
@Tobias-Fischer
Copy link
Contributor

Thanks a lot Silvio! I think we tried previously to add a test but for some reason we couldn't manage, is that right? It would be great to catch those subtleties at build time.

@github-actions github-actions bot merged commit 80de8a3 into conda-forge:master Jan 28, 2022
@traversaro
Copy link
Contributor Author

I think we tried previously to add a test but for some reason we couldn't manage, is that right? It would be great to catch those subtleties at build time.

Yes, we tried in the past but it was not simple, it would be great to catch this automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in Gazebo 11.10 on Windows
3 participants