-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a libgdal-arrow-parquet package #679
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
f16f19f
to
65620c7
Compare
@conda-forge-admin, please rerender |
@rouault , you are amazing! My two cents and I could be totally wrong here, but So I don't know how far this PR can get until that is cleared... |
b59979a
to
a5131dd
Compare
a5131dd
to
38aaeab
Compare
I noticed the failed win64 openssl=3 build picked up |
38aaeab
to
70b6fd4
Compare
Selfishly, for GDAL needs, we don't need arrow-cpp to be built against aws-sdk-cpp, as GDAL plugs its VSI I/O layer into libarrow, and thus can access AWS S3 through /vsis3/ . Would dropping aws-sdk-cpp dependency from arrow-cpp be acceptable ? |
@xhochy sorry to ping you here but do you think you can help us navigate this arrow-parquet dependency for gdal? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be wise to wait until we have merged arrow-cpp=10
as this resolves the dependency solve issue with aws-sdk-cpp
hopefully. We can also spit the arrow-cpp
package a bit more up to have fewer dependencies but I think the core already links to aws-sdk-cpp
, i.e. we won't be able to get rid of that.
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug. |
which contains the ogr_Arrow.so/dylib/dll and ogr_Parquet.so/dylib/dll plugins The libgdal-arrow-parquet build reuses the same build directory as libgdal, hence we just to have to turn on the required dependency and drivers in the build_arrow_parquet.sh/bat scripts. Fixes conda-forge#628
ee19455
to
1bc4ddc
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/gdal-feedstock/actions/runs/3653614116. |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/gdal-feedstock/actions/runs/3653660196. |
cf23f8c
to
32557d8
Compare
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/gdal-feedstock/actions/runs/3653704985. |
Co-authored-by: h-vetinari <h.vetinari@gmx.com>
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/gdal-feedstock/actions/runs/3654269582. |
(if the older arrow versions give problems, I think it's also perfectly fine to only have this for arrow-cpp 10 for now, since it's a new install feature for conda users anyway) |
@rouault, your last few commits make no sense, as they will be immediately undone whenever the feedstock gets rerendered. Also, what's the issue with curl? If you don't want it, you'll have to remove it from the host-dependencies. By the argument of Joris, I think it would be much easier to just skip the new output for older arrow version |
Probably. I told you I was a conda-forge noob ;-) well, I did them based on the error messages in failed builds, and looking at the diff of this PR against main. The added curl: 7 constraint was new to this PR and totally unrelated. We do want curl, but some package didn't like that constraint. |
Co-authored-by: h-vetinari <h.vetinari@gmx.com>
@conda-forge-admin, please rerender |
…nda-forge-pinning 2022.12.09.08.14.11
Hooray: green build! |
Add a libgdal-arrow-parquet package which contains the ogr_Arrow.so/dylib/dll and ogr_Parquet.so/dylib/dll plugins
The libgdal-arrow-parquet build reuses the same build directory as libgdal, hence we just to have to turn on the required dependency and drivers in the build_arrow_parquet.sh/bat scripts.
Fixes #628
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)