Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix libgdal-pdf that fails to work #975

Closed
wants to merge 1 commit into from

Conversation

rouault
Copy link
Contributor

@rouault rouault commented Aug 13, 2024

due to poppler not being found when building libgdal-core

which causes the plugin to emit the following and not being functional:

Warning 1: Driver PDF declares DMD_OPENOPTIONLIST whereas its proxy doesn't declare it or with a different value
Warning 1: Driver PDF declares DCAP_OPEN whereas its proxy doesn't declare it or with a different value
Warning 1: Driver PDF declares DMD_SUBDATASETS whereas its proxy doesn't declare it or with a different value
Warning 1: Proxy driver PDF declares a pfnIdentify callback whereas the real driver does not.
Warning 1: Driver PDF declares a pfnOpen callback whereas its proxy doest not declare DCAP_OPEN

due to poppler not being found when building libgdal-core

which causes the plugin to emit the following and not being functional:
```
Warning 1: Driver PDF declares DMD_OPENOPTIONLIST whereas its proxy doesn't declare it or with a different value
Warning 1: Driver PDF declares DCAP_OPEN whereas its proxy doesn't declare it or with a different value
Warning 1: Driver PDF declares DMD_SUBDATASETS whereas its proxy doesn't declare it or with a different value
Warning 1: Proxy driver PDF declares a pfnIdentify callback whereas the real driver does not.
Warning 1: Driver PDF declares a pfnOpen callback whereas its proxy doest not declare DCAP_OPEN
```
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@akrherz
Copy link
Contributor

akrherz commented Aug 13, 2024

poppler was one of the main things that drove #722. Does poppler just need to be present at build time and not at run?

@rouault
Copy link
Contributor Author

rouault commented Aug 13, 2024

Does poppler just need to be present at build time and not at run?

just at build time. Technically it doesn't even need to be there. Just having -DHAVE_POPPLER in CXXFLAGS of libgdal-core should be enough

@akrherz
Copy link
Contributor

akrherz commented Aug 13, 2024

just at build time.

I believe adding it as a dep will cause it to be added as a run dep, unless we do some tricks. Will research this more soon and hopefully I am wrong :)

@rouault
Copy link
Contributor Author

rouault commented Aug 13, 2024

Technically it doesn't even need to be there. Just having -DHAVE_POPPLER in CXXFLAGS of libgdal-core should be enough

trying that approach in #976

@xylar
Copy link
Contributor

xylar commented Aug 13, 2024

I believe adding it as a dep will cause it to be added as a run dep, unless we do some tricks.

I don't think so. I didn't see any run_exports:
https://github.com/conda-forge/poppler-feedstock/blob/main/recipe/meta.yaml

@akrherz
Copy link
Contributor

akrherz commented Aug 13, 2024

Can a simple test be added to the libgdal-pdf artifact section to ensure that it is working?

@rouault
Copy link
Contributor Author

rouault commented Aug 13, 2024

Can a simple test be added to the libgdal-pdf artifact section to ensure that it is working?

attempted in #976 with 41f6713

@rouault
Copy link
Contributor Author

rouault commented Aug 14, 2024

closing as superseded per #976

@rouault rouault closed this Aug 14, 2024
github-actions bot added a commit that referenced this pull request Aug 14, 2024
automerged PR by conda-forge/automerge-action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants