[DNM] gensim v3.6.0 #14

regro-cf-autotick-bot · 2018-09-20T19:24:22Z

It is very likely that the current package version for this feedstock is out of date.
Notes and instructions for merging this PR:

Please check that the dependencies have not changed.
Please merge the PR only after the tests have passed.
Feel free to push to the bot's branch to update this PR if needed.
The bot will almost always only open one PR per version.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one.

_{This PR was created by the cf-regro-autotick-bot.

The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.

Finally, feel free to drop us a line if there are any issues!}

conda-forge-linter · 2018-09-20T19:24:28Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

Whenever possible python packages should use pip. See https://conda-forge.org/docs/meta.html#use-pip

conda-forge-linter · 2018-09-21T01:39:50Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

The build section contained an unexpected subsection name. build is not a valid subsection name.
The build section contained an unexpected subsection name. host is not a valid subsection name.
The build section contained an unexpected subsection name. run is not a valid subsection name.

For recipe:

Whenever possible python packages should use pip. See https://conda-forge.org/docs/meta.html#use-pip

conda-forge-linter · 2018-09-21T01:43:55Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

Whenever possible python packages should use pip. See https://conda-forge.org/docs/meta.html#use-pip

menshikh-iv · 2018-09-21T02:00:33Z

@souravsingh we added C++ code to gensim with c++11 standard any ideas how to fix build?

menshikh-iv · 2018-09-21T07:15:17Z

@jakirkham can you give us an advice please, what we should do: we add more Cython to gensim (but this part translated to cpp using c++11 standard, earlier it was only pure-C) and now this can't be built for conda? I think we should do something with compilers, but I'm not familiar with forge ecosystem.

souravsingh · 2018-09-21T13:04:20Z

@menshikh-iv I think we would need to do something similar to what shogun does- https://github.com/conda-forge/shogun-feedstock/blob/master/recipe/meta.yaml#L73

I believe we should wait for a comment from either @isuruf or @jakirkham before we can change anythng.

isuruf · 2018-09-21T13:44:43Z

@conda-forge-admin, please rerender.

conda-forge-linter · 2018-09-21T13:45:52Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

jakirkham · 2018-09-21T16:11:39Z

@conda-forge-admin, please re-render.

jakirkham · 2018-09-21T16:16:17Z

@conda-forge-admin, please re-render.

(Third time is the charm 🍀)

conda-forge-linter · 2018-09-21T16:17:12Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

Whenever possible python packages should use pip. See https://conda-forge.org/docs/meta.html#use-pip

jakirkham · 2018-09-21T16:28:47Z

can you give us an advice please, what we should do: we add more Cython to gensim (but this part translated to cpp using c++11 standard, earlier it was only pure-C) and now this can't be built for conda?

So looks like @isuruf already helped out on getting this feedstock using the new compiler syntax, which will help with a variety of things. The feedstock is also now re-rendered to take advantage of this functionality. The compilers available should already support C++11 (with the exception of Python 2.7 on Windows, which has too old of a compiler). We may need to add an explicit C++ flag to use C++11 support with the compilers (i.e. -std=c++11). On Windows IIRC they skipped straight to C++14, so the flag used will differ between the two platforms (i.e. -std=c++14). HTH

menshikh-iv · 2018-09-22T06:58:42Z

Thanks @isuruf @jakirkham for help

We already have some compiler options (for Linux & OSX)
https://github.com/RaRe-Technologies/gensim/blob/676372a106d093ea2f47d246585e1b386240192f/setup.py#L265-L272

I see than now all builds failed, both OS with same error (strange, because standrat wheel for windows builded correctly, see https://ci.appveyor.com/project/piskvorky/gensim-wheels/build/1.0.112, same for linux)

[00:11:20] ./gensim/models/word2vec_corpusfile.cpp(591): fatal error C1083: Cannot open include file: 'fast_line_sentence.h': No such file or directory
[00:11:20] command 'C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\BIN\\amd64\\cl.exe' failed with exit status 2

though this file exist in distribution https://github.com/RaRe-Technologies/gensim/blob/develop/gensim/models/fast_line_sentence.h (UPD this file missing in .tar.gz, maybe when I add it, the problem will be resolved) fixed piskvorky/gensim#2194

So, questions:

~~Should I add another compilation options?~~ No, it works well with already existing options
~~How can I build without release (i.e. PyPI)? I'm not sure that adding .h the file will fix all issues and want to be sure that it works before official release?~~ Found in documentation and already use it
How to add OSX to build (since we have started setting up conda-forge builds, I'm pretty sure that I'll have an issue with it here, see Setup build for MacOSX #11 & osx build with unittest #12 )?
How to add python3.7?

menshikh-iv · 2018-09-22T12:52:10Z

@conda-forge-admin please re-render.

conda-forge-linter · 2018-09-22T12:52:55Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

conda-forge-linter · 2018-09-22T13:06:25Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

Whenever possible python packages should use pip. See https://conda-forge.org/docs/meta.html#use-pip

souravsingh · 2018-09-22T17:42:03Z

@menshikh-iv The tests for package now pass. Do you want me to merge the PR right now?

menshikh-iv · 2018-09-22T19:21:14Z

@souravsingh no, I just check a hypothesis than an issue in missing files. I'll use this PR as the place for improving current configuration (I want to add py37 & OSX builds, see my comment above). In parallel - apply needed changes for Gensim and in next gensim release I'll apply all needed changes & merge (current PR or new one with all changes)

menshikh-iv · 2018-09-24T14:32:24Z

@isuruf @jakirkham I'll be really appreciate if you'll help me with this things

Add OSX build (we have several failed attempts in Setup build for MacOSX #11 & osx build with unittest #12)
Add python3.7

jakirkham · 2018-09-24T17:54:30Z

Add OSX build

I'm sorry @menshikh-iv. I don't really have bandwidth for this unfortunately. 😞

Add python3.7

This will happen eventually as we are doing a rebuild of the whole stack. It will take a bit as there are many simultaneous rebuilds being combined into one. ( conda-forge/conda-forge.github.io#649 )

souravsingh · 2018-09-24T20:59:59Z

@menshikh-iv Rebuild for Python 3.7 arrived for one of the feedstock I maintain- conda-forge/validictory-feedstock#7

I would say support for Python 3.7 would arrive soonish.

menshikh-iv · 2018-09-25T03:25:32Z

@souravsingh great, I'll wait for it

menshikh-iv · 2018-09-25T03:26:06Z

@jakirkham no problem

menshikh-iv · 2018-10-05T07:27:30Z

continued in #15

updated v3.6.0

74e630a

souravsingh requested a review from menshikh-iv September 20, 2018 19:29

try to fix compilation

b84d7b7

fix

11db8dc

Update meta.yaml

023a221

MNT: Re-rendered with conda-smithy 3.1.12 and pinning 2018.09.20

5657816

test build (add missing files to tarball)

d4b465a

update link (previous was private)

f50a0fc

menshikh-iv mentioned this pull request Sep 22, 2018

Add missing content to tarball piskvorky/gensim#2194

Merged

menshikh-iv changed the title ~~gensim v3.6.0~~ [DNM] gensim v3.6.0 Sep 22, 2018

menshikh-iv removed their request for review September 24, 2018 14:33

menshikh-iv mentioned this pull request Oct 5, 2018

Next gensim release #15

Merged

menshikh-iv closed this Oct 5, 2018

regro-cf-autotick-bot deleted the 3.6.0 branch February 25, 2019 13:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DNM] gensim v3.6.0 #14

[DNM] gensim v3.6.0 #14

regro-cf-autotick-bot commented Sep 20, 2018

conda-forge-linter commented Sep 20, 2018

conda-forge-linter commented Sep 21, 2018

conda-forge-linter commented Sep 21, 2018

menshikh-iv commented Sep 21, 2018

menshikh-iv commented Sep 21, 2018 •

edited

Loading

souravsingh commented Sep 21, 2018

isuruf commented Sep 21, 2018 •

edited

Loading

conda-forge-linter commented Sep 21, 2018

jakirkham commented Sep 21, 2018

jakirkham commented Sep 21, 2018

conda-forge-linter commented Sep 21, 2018

jakirkham commented Sep 21, 2018

menshikh-iv commented Sep 22, 2018 •

edited

Loading

menshikh-iv commented Sep 22, 2018

conda-forge-linter commented Sep 22, 2018

conda-forge-linter commented Sep 22, 2018

souravsingh commented Sep 22, 2018

menshikh-iv commented Sep 22, 2018 •

edited

Loading

menshikh-iv commented Sep 24, 2018

jakirkham commented Sep 24, 2018

souravsingh commented Sep 24, 2018 •

edited

Loading

menshikh-iv commented Sep 25, 2018

menshikh-iv commented Sep 25, 2018

menshikh-iv commented Oct 5, 2018

[DNM] gensim v3.6.0 #14

[DNM] gensim v3.6.0 #14

Conversation

regro-cf-autotick-bot commented Sep 20, 2018

conda-forge-linter commented Sep 20, 2018

conda-forge-linter commented Sep 21, 2018

conda-forge-linter commented Sep 21, 2018

menshikh-iv commented Sep 21, 2018

menshikh-iv commented Sep 21, 2018 • edited Loading

souravsingh commented Sep 21, 2018

isuruf commented Sep 21, 2018 • edited Loading

conda-forge-linter commented Sep 21, 2018

jakirkham commented Sep 21, 2018

jakirkham commented Sep 21, 2018

conda-forge-linter commented Sep 21, 2018

jakirkham commented Sep 21, 2018

menshikh-iv commented Sep 22, 2018 • edited Loading

menshikh-iv commented Sep 22, 2018

conda-forge-linter commented Sep 22, 2018

conda-forge-linter commented Sep 22, 2018

souravsingh commented Sep 22, 2018

menshikh-iv commented Sep 22, 2018 • edited Loading

menshikh-iv commented Sep 24, 2018

jakirkham commented Sep 24, 2018

souravsingh commented Sep 24, 2018 • edited Loading

menshikh-iv commented Sep 25, 2018

menshikh-iv commented Sep 25, 2018

menshikh-iv commented Oct 5, 2018

menshikh-iv commented Sep 21, 2018 •

edited

Loading

isuruf commented Sep 21, 2018 •

edited

Loading

menshikh-iv commented Sep 22, 2018 •

edited

Loading

menshikh-iv commented Sep 22, 2018 •

edited

Loading

souravsingh commented Sep 24, 2018 •

edited

Loading