-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Do not merge: A potential recipe for handing VC versions. #10
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
|
||
requirements: | ||
build: | ||
- gmp [not win] | ||
- vc # [win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing this should also be pinned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure actually - the vc package doesn't contain anything, and I'm not sure it even influences any package resolution. Maybe it does need to be pinned though in order to control the dependencies being installed.
This is a very interesting proposal. I like it. I think it could get shorter over time, but this is a very good start. I kept asking myself "but where's Python?" - and of course, it doesn't need to be there. Thanks for pushing this forward. |
- python [win] | ||
- gmp [not win] | ||
- vc {{ VC_VERSION }} # [win] | ||
- gmp # [not win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use the mpir package (https://github.com/conda-forge/mpir-feedstock) for windows build. MPIR is a fork of GMP and can be built on windows. API is the same except for some long vs long long differences.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably won't worry about it in this PR as this is aimed to try out the vc
package with a matrix, but it is definitely something worth keeping in mind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put this idea in an issue ( #11 ) so we can better track and address it.
Another solution to this problem is in PR ( conda-forge/tk-feedstock#20 ). The same thing could easily be ported here. |
Obsolete now that conda-build=3 can be used. |
So, here are some improvements to the way we manage the
vc
problem for Windows.Ping @msarahan as there are some important implications here.
Things to note / answer:
build
component could be handled by conda-build automatically based on the current vc version being used, or alternatively by having yet another special environment variable.VC_VERSION
environment variable